From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 73B3A374F for ; Mon, 3 Jul 2017 15:01:51 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2017 06:01:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,303,1496127600"; d="scan'208";a="1147313754" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 03 Jul 2017 06:01:48 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX151.ger.corp.intel.com ([169.254.4.191]) with mapi id 14.03.0319.002; Mon, 3 Jul 2017 14:01:48 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "olivier.matz@6wind.com" , "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to standard event rings Thread-Index: AQHS8bLMfl/tcP6vRUiWN8KqdacxIKJCChRA///2CYCAABVTUA== Date: Mon, 3 Jul 2017 13:01:47 +0000 Message-ID: References: <20170607133620.275801-1-bruce.richardson@intel.com> <20170630150621.156365-1-bruce.richardson@intel.com> <20170630150621.156365-6-bruce.richardson@intel.com> <20170703124439.GA9022@jerin> In-Reply-To: <20170703124439.GA9022@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWY1ZjNmZGQtOWNiZi00OTFkLTljY2QtZmRkMmUzMDI3YmEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InRpNlViN29pWFMzYWg3NVR6VjFDUW5KSU9DWG9mcURUaEJDb25PbmhmYkk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to standard event rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 13:01:52 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, July 3, 2017 1:45 PM > To: Van Haaren, Harry > Cc: olivier.matz@6wind.com; Richardson, Bruce ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to s= tandard event > rings >=20 > -----Original Message----- > > Date: Mon, 3 Jul 2017 12:28:32 +0000 > > From: "Van Haaren, Harry" > > To: "jerin.jacob@caviumnetworks.com" > > CC: "olivier.matz@6wind.com" , "Richardson, Bru= ce" > > , "dev@dpdk.org" , "Richards= on, > > Bruce" > > Subject: RE: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to > > standard event rings > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > Sent: Friday, June 30, 2017 4:06 PM > > > To: dev@dpdk.org > > > Cc: olivier.matz@6wind.com; jerin.jacob@caviumnetworks.com; Richardso= n, Bruce > > > > > > Subject: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to s= tandard event > rings > > > > > > Now that we have a standard event ring implementation for passing eve= nts > > > core-to-core, use that in place of the custom event rings in the soft= ware > > > eventdev. > > > > > > Signed-off-by: Bruce Richardson > > > > Agree with 99% of this patch, but due to the implementation (with memzo= ne lookup), > > we need to change one part of the sw_port_setup() function. > > > > The change is required to allow port_setup() to be called multiple time= s on the same > > port, which is required to re-configure a port that has already been co= nfigured once. > > > > I can send a separate fix, or I could re-spin Bruce's 5 patches, and in= clude the fix. > > > > Given this is a small, non-datapath modification to the SW PMD, my pref= erence is to > > ack this patch once I've posted a separate patch fix for the SW PMD. > > > > @Jerin, any preference? >=20 > I think, you can send it as a separate patch. I can squash the fix patch = with this > patch or apply it as separate one if you are not concerned about > breaking when we do "git bisect". Let me know. Can be squashed then, please and thanks! Then this patch itself (5/5) is Acked-by: Harry van Haaren