From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6976C374 for ; Fri, 7 Jul 2017 18:28:30 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2017 09:28:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,323,1496127600"; d="scan'208";a="284254015" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 07 Jul 2017 09:28:28 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX154.ger.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0319.002; Fri, 7 Jul 2017 17:28:27 +0100 From: "Van Haaren, Harry" To: 'Jerin Jacob' CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [PATCH v3 5/7] service cores: enable event/sw with service Thread-Index: AQHS83shtd2tM+ojYE6Qw6/cfP9MuqJDb4oAgANP8aA= Date: Fri, 7 Jul 2017 16:28:27 +0000 Message-ID: References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-6-git-send-email-harry.van.haaren@intel.com> <20170704105229.GA12473@jerin> In-Reply-To: <20170704105229.GA12473@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTg4ZDYyOWItNDlkMS00MGU5LThlYmQtN2U1NmJjMzc4MmIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZMNCtNQ2toUXNidDdEMFZrYWRSbWNQc3RYQ255UnRwVWZRcER6U3hIUUE9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/7] service cores: enable event/sw with service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 16:28:30 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, July 4, 2017 11:53 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; thomas@monjalon.net; Wiles, Keith ; Richardson, > Bruce > Subject: Re: [PATCH v3 5/7] service cores: enable event/sw with service >=20 > -----Original Message----- > > Date: Sun, 2 Jul 2017 22:35:12 +0100 > > From: Harry van Haaren > > To: dev@dpdk.org > > CC: jerin.jacob@caviumnetworks.com, thomas@monjalon.net, > > keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren > > > > Subject: [PATCH v3 5/7] service cores: enable event/sw with service > > X-Mailer: git-send-email 2.7.4 > > > > This commit shows how easy it is to enable a specific > > DPDK component with a service callback, in order to get > > CPU cycles for it. > > > > The beauty of this method is that the service is unaware > > of how much CPU time it is getting - the application can > > decide how to split and slice cores and map them to the > > registered services. > > > > Signed-off-by: Harry van Haaren > > + > > + /* check a service core is mapped to this service */ > > + struct rte_service_spec *s =3D rte_service_get_by_name(sw->service_na= me); > > + if (!rte_service_is_running(s)) > > + SW_LOG_ERR("Warning: No Service core enabled on service %s\n", > > + s->name); >=20 > For now, we can print just Warning. Once we remove schedule api from > eventdev then we can make it as error. Right? Yes correct. > Acked-by: Jerin Jacob Thanks, will include in v+1.