From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F4233374 for ; Fri, 7 Jul 2017 18:28:40 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2017 09:28:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,323,1496127600"; d="scan'208";a="108738927" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2017 09:28:38 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by irsmsx110.ger.corp.intel.com ([169.254.15.126]) with mapi id 14.03.0319.002; Fri, 7 Jul 2017 17:28:37 +0100 From: "Van Haaren, Harry" To: 'Jerin Jacob' CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [PATCH v3 2/7] service cores: EAL init changes Thread-Index: AQHS83sfaRg1tZlBDkOavAphhJbe2KJDe5AAgANFuVA= Date: Fri, 7 Jul 2017 16:28:37 +0000 Message-ID: References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-3-git-send-email-harry.van.haaren@intel.com> <20170704113531.GA14921@jerin> In-Reply-To: <20170704113531.GA14921@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGEyOTE1Y2YtODBjMS00M2ZmLTk1MzAtZTIxMzIwZDc5NWQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNi41LjkuMyIsIlRydXN0ZWRMYWJlbEhhc2giOiJraEdlbEo0T0dwWTBhQW1EeXppSDJ3SzhrZnhObWg1QjRsMU56MkFiekhZPSJ9 x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/7] service cores: EAL init changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 16:28:41 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, July 4, 2017 12:36 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; thomas@monjalon.net; Wiles, Keith ; Richardson, > Bruce > Subject: Re: [PATCH v3 2/7] service cores: EAL init changes >=20 > -----Original Message----- > > Date: Sun, 2 Jul 2017 22:35:09 +0100 > > From: Harry van Haaren > > To: dev@dpdk.org > > CC: jerin.jacob@caviumnetworks.com, thomas@monjalon.net, > > keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren > > > > Subject: [PATCH v3 2/7] service cores: EAL init changes > > X-Mailer: git-send-email 2.7.4 > > > > This commit shows the changes required in rte_eal_init() > > to transparently launch the service threads. The threads > > are launched into the service worker functions here because > > after rte_eal_init() the application is not gauranteed to > > call any other DPDK API. > > > > As the registration of services happens at initialization > > time, the services that require CPU time are already available > > when we reach the end of rte_eal_init(). > > > > Signed-off-by: Harry van Haaren > > > > --- > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxap= p/eal/eal.c > > index 7c78f2d..d63dd87 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal.c > > +++ b/lib/librte_eal/linuxapp/eal/eal.c > > @@ -78,6 +78,7 @@ > > #include > > #include > > #include > > +#include >=20 > Not included this header file for bsdapp compilation. It should fail to > compile. Right? Fixed.