From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E38307CC6 for ; Mon, 10 Jul 2017 10:18:36 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2017 01:18:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,339,1496127600"; d="scan'208";a="991142715" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 10 Jul 2017 01:18:34 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX103.ger.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002; Mon, 10 Jul 2017 09:18:33 +0100 From: "Van Haaren, Harry" To: Thomas Monjalon CC: "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter Thread-Index: AQHS9z/bU6khpYQmpEyBLJOXi7lmgKJMAKOAgAC3zZA= Date: Mon, 10 Jul 2017 08:18:33 +0000 Message-ID: References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499445667-32588-1-git-send-email-harry.van.haaren@intel.com> <3143159.FqVZFIAO7L@xps> In-Reply-To: <3143159.FqVZFIAO7L@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTY3ODE2OWQtMzk5OC00M2JlLTljOGYtNzQyYTA3ZDU5OTViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlB0K2RaSFhxRlpNNzlMeEl4dlJzRzR6OWpreUxPdjNMZXNKNnZqMzBGSnc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 08:18:37 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday, July 9, 2017 11:09 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Wiles, Keith ; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter >=20 > 07/07/2017 18:41, Harry van Haaren: > > v4: > > - Range of fixes as suggested by Jerin > > - Improved unit tests, ensuring ex-service cores become available to ap= p > > - Added functions to EXPERIMENTAL tag in .map files (Thomas) > > - Added @warning experimental notes to Doxygen API documentation (Thoma= s) > > - Various smaller fixes / cleanups > > - See commit notes for details >=20 > I feel we need to wait approval from some reviewers, at least from Jerin > who was very active on this series. Agreed that more reviewing eyes would be good. > It means it misses the first release candidate, and it is a problem > because this feature is updating the core. Correct service cores does update the core, however a review of the code-pa= ths taken if the service cores -s switch is not used shows that it will have al= most no impact on the EAL code path. > Naive question: do we really want it in 17.08? I think merging in 17.08 allow us to progress on integrating services and D= PDK, so I see value in including in this release.