From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2F90E3250 for ; Tue, 11 Jul 2017 14:33:02 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 11 Jul 2017 05:33:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,346,1496127600"; d="scan'208";a="109956760" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 11 Jul 2017 05:33:00 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX101.ger.corp.intel.com ([169.254.1.242]) with mapi id 14.03.0319.002; Tue, 11 Jul 2017 13:32:59 +0100 From: "Van Haaren, Harry" To: Thomas Monjalon , Jerin Jacob CC: "dev@dpdk.org" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [PATCH v4 1/7] service cores: header and implementation Thread-Index: AQHS9z/jwjXkVTa0DESrgHxIpVBb1KJOQHgAgAAXsoCAADtJkA== Date: Tue, 11 Jul 2017 12:32:58 +0000 Message-ID: References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499445667-32588-2-git-send-email-harry.van.haaren@intel.com> <20170711082950.GB29792@jerin> <13391507.vzRJCuhnFb@xps> In-Reply-To: <13391507.vzRJCuhnFb@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWMzYWM2OGMtMmQ4Ny00ZmI0LThmNWUtZDZhMmFkYzQ2YzlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IldFR2pDQmh0dnJJSG13dzAxS01USTZnTDdSRXNwRENHeXo5S2c4TlloOTQ9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/7] service cores: header and implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 12:33:03 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 11, 2017 10:55 AM > To: Jerin Jacob ; Van Haaren, Harry > > Cc: dev@dpdk.org; Wiles, Keith ; Richardson, Bruce > > Subject: Re: [PATCH v4 1/7] service cores: header and implementation >=20 > 11/07/2017 10:29, Jerin Jacob: > > IMO, We don't need to expose rte_service_private.h to application. If > > you agree, add the following or similar change >=20 > If it must not be exposed, the file should not have the prefix rte_ > In doc/api/doxy-api.conf, every files with rte_ prefix will be processed > for doxygen documentation: > FILE_PATTERNS =3D rte_*.h The service registration API should be exposed to the application. Imagine a use case where the application wants to run services *and* an app= lication specific function on the same core. In the current implementation= this is possible, as the application can register a service. The app then = configures all services (including its own "app-service") to run on a servi= ce lcore. If we hide the service registration from the application, we make it imposs= ible for the application to multiplex services and application specific wor= kloads on a single core. I strongly prefer of leaving the header as is. Given we have EXPERIMENTAL t= ag, ABI/API are not a concern until later - we have time to figure out if t= he service-registration API is good enough in current form, before we commi= t to it. I'll send v5 asap with headers as is.