From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 506FB2E83 for ; Wed, 12 Jul 2017 15:34:06 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2017 06:33:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,349,1496127600"; d="scan'208";a="125673671" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga005.fm.intel.com with ESMTP; 12 Jul 2017 06:33:17 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Wed, 12 Jul 2017 14:32:32 +0100 From: "Van Haaren, Harry" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [Process] Git Fixline Suggestion Thread-Index: AdL66dcZ/jUU9uIeQ92IB/61O2diQAACmHAAAAe7/WA= Date: Wed, 12 Jul 2017 13:32:31 +0000 Message-ID: References: <1777813.DZOk1ehyER@xps> In-Reply-To: <1777813.DZOk1ehyER@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTViYmE4MTEtYmRmYS00YzJiLWJmMDgtOTMxNTMwNjgyNmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtPRTBjRExaNjIzTHNyQWNaY0cyNlN1VWorSFwvZEpjQkp0U3R5WUFiK3hvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 13:34:07 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, July 12, 2017 11:50 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion >=20 > 12/07/2017 10:40, Van Haaren, Harry: > > Hi All, > > > > I propose to add CC: to the output of the git fixline command[= 1]. > > > > The logic here is that if it is a fix to the previous code, the origina= l author of that > code should be informed. Currently the author must read the mailing-list = carefully in > order to ensure that no patches are missed, that fix code that they are t= he author of. > > > > The new workflow is the same as before: copy the output of "git fixline= " into the commit > message. The output would now be two lines as follows: > > > > Fixes: 17b8320a3e11 ("vhost: remove index parameter") > > cc: author@domain.com > > > > > > The following git fixline achieves this: > > > > git log -1 --abbrev=3D12 --format=3D"Fixes: %h (\"%s\")%nCC:%ae" > > > > > > Opinions? -Harry >=20 > Good idea. > Two comments: >=20 > - minor nit: CC should be Cc to be consistent with what is suggested > by check-git-log.sh for stable@dpdk.org. Sure. > - Do we want to keep this Cc in the git history or is it just > to notify people on the mailing list? > I think it is good to keep in history the tags Acked-by: or Reviewed-by:. > But if the author does not review the fix, I do not see the benefit of > saving his name in the history. Agreed. I'll send a patch in-reply-to this message to update contributing guideline= s.