From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8E57A3253 for ; Mon, 17 Jul 2017 18:16:53 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 17 Jul 2017 09:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="287891210" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 17 Jul 2017 09:16:51 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by irsmsx110.ger.corp.intel.com ([169.254.15.199]) with mapi id 14.03.0319.002; Mon, 17 Jul 2017 17:16:50 +0100 From: "Van Haaren, Harry" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH] service: add corelist to EAL arguments Thread-Index: AQHS/xB0+sGLNrxSCkmvUOn1c3VgfKJYGsqAgAAQ/HD///PJgIAAEk4A Date: Mon, 17 Jul 2017 16:16:49 +0000 Message-ID: References: <2348349.WgB7oMYfnC@xps> <1500304914-42805-1-git-send-email-harry.van.haaren@intel.com> <2601191342CEEE43887BDE71AB977258404CA1B4@IRSMSX103.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258404CA254@IRSMSX103.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258404CA254@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDYwYzUyMWYtYTRiNy00NzgxLWJjZGYtYzY5OGE0ZWQ2OWU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9OWWJEeER4MXBPXC9vcGRnVmh1TDA2UU9KZ2dzTjZBV2JmYzVVaEhuT1BvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] service: add corelist to EAL arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 16:16:54 -0000 > From: Ananyev, Konstantin > Sent: Monday, July 17, 2017 5:11 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com > Subject: RE: [dpdk-dev] [PATCH] service: add corelist to EAL arguments >=20 >=20 >=20 > > -----Original Message----- > > From: Van Haaren, Harry > > Sent: Monday, July 17, 2017 4:58 PM > > To: Ananyev, Konstantin ; dev@dpdk.org > > Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com > > Subject: RE: [dpdk-dev] [PATCH] service: add corelist to EAL arguments > > > > > From: Ananyev, Konstantin > > > Sent: Monday, July 17, 2017 4:54 PM > > > To: Van Haaren, Harry ; dev@dpdk.org > > > Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; Van Haaren, = Harry > > > > > > Subject: RE: [dpdk-dev] [PATCH] service: add corelist to EAL argument= s > > > > > > Hi Harry, > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haar= en > > > > Sent: Monday, July 17, 2017 4:22 PM > > > > To: dev@dpdk.org > > > > Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; Van Haaren= , Harry > > > > > > > Subject: [dpdk-dev] [PATCH] service: add corelist to EAL arguments > > > > > > > > This commit allows the -S (captial 's') to be used to indicate > > > > a corelist for Services. This is a "nice to have" patch, and does > > > > not modify any of the service core functionality. > > > > > > > > Suggested-by: Jerin Jacob > > > > Suggested-by: Thomas Monjalon > > > > Signed-off-by: Harry van Haaren > > > > --- > > > > lib/librte_eal/common/eal_common_options.c | 74 ++++++++++++++++++= ++++++++++++ > > > > 1 file changed, 74 insertions(+) > > > > > > > > diff --git a/lib/librte_eal/common/eal_common_options.c > > > b/lib/librte_eal/common/eal_common_options.c > > > > index 00265d6..696a627 100644 > > > > --- a/lib/librte_eal/common/eal_common_options.c > > > > +++ b/lib/librte_eal/common/eal_common_options.c > > > > @@ -65,6 +65,7 @@ eal_short_options[] =3D > > > > "d:" /* driver */ > > > > "h" /* help */ > > > > "l:" /* corelist */ > > > > + "S:" /* service corelist */ > > > > "m:" /* memory size */ > > > > "n:" /* memory channels */ > > > > "r:" /* memory ranks */ > > > > @@ -402,6 +403,72 @@ eal_parse_coremask(const char *coremask) > > > > } > > > > > > > > > > Do we need a new parsing function here? > > > Can't we reuse at least part of '-l' parsing code? > > > Konstantin > > > > > > Yep we should - in this instance (post-RC2..) I don't want to rock-the-= boat and change > any existing EAL functionality. > > > > During review of eventdev-sample-app and service-cores, Jerin had noted= that we are > duplicating various functions for parsing strings, and > > really we should cleanup into a single function to call from all of the= m. That should be > scheduled as post 17.08 rework. >=20 > Sound ok to me then. Cool. I should note; good point, absolutely agree, and thanks for review :)