From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] all: refactor coding style
Date: Wed, 19 Jul 2017 09:24:38 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C3DF8F@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tiwei Bie
> Sent: Wednesday, July 19, 2017 10:07 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net
> Subject: [dpdk-dev] [PATCH] all: refactor coding style
>
> Remove the unwanted spaces before `;' across DPDK source code
> by below one-liner with some minor manual refinements.
>
> find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g'
>
> The fixes for cmdline library are skipped, because it has a
> different coding style. It deserves a separate cleanup if
> necessary. The fixes for drivers' base code are also skipped
> to keep the base code intact.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Hi Tiwei,
Although the idea and motivation for code-cleanup are good, performing
large cleanup across a code-base is not a good solution. The reason that
these types of cleanups (or even re-formatting the entire codebase) are not
performed often is that it "invalidates" any currently-in-progress patch-sets.
As a result, more work is required from many contributors to rebase useful
features due to across-the-board white-space cleanups.
Just expressing concern that we need to think carefully about the impacts
of such a patch.
Regards, -Harry
next prev parent reply other threads:[~2017-07-19 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 9:06 Tiwei Bie
2017-07-19 9:24 ` Van Haaren, Harry [this message]
2017-07-19 10:23 ` Tiwei Bie
2017-07-20 7:56 ` Jens Freimann
2017-07-20 8:32 ` Thomas Monjalon
2017-07-20 9:01 ` Tiwei Bie
2017-07-19 10:45 ` Trahe, Fiona
2017-07-20 5:04 ` Shreyansh Jain
2017-07-20 5:53 ` Tiwei Bie
2017-07-20 7:13 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C3DF8F@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).