From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BBCA0532C for ; Wed, 19 Jul 2017 11:24:44 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2017 02:24:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,380,1496127600"; d="scan'208";a="1197153132" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2017 02:24:40 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX154.ger.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 10:24:38 +0100 From: "Van Haaren, Harry" To: "Bie, Tiwei" CC: "thomas@monjalon.net" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] all: refactor coding style Thread-Index: AQHTAG8MIESJlv6BYU2xeBaOCGUBSKJa3eXQ Date: Wed, 19 Jul 2017 09:24:38 +0000 Message-ID: References: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> In-Reply-To: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWFhNTFmYjctZDk2MS00NjAyLWExNGItMDM0YjkwOWY3MDA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InJPNzV1dW1TSnI2cE1OTG9rWUF2bGtYTFB5U3phQk1Zc2pXQTRzb3lucTg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] all: refactor coding style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 09:24:45 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style >=20 > Remove the unwanted spaces before `;' across DPDK source code > by below one-liner with some minor manual refinements. >=20 > find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' >=20 > The fixes for cmdline library are skipped, because it has a > different coding style. It deserves a separate cleanup if > necessary. The fixes for drivers' base code are also skipped > to keep the base code intact. >=20 > Signed-off-by: Tiwei Bie Hi Tiwei, Although the idea and motivation for code-cleanup are good, performing large cleanup across a code-base is not a good solution. The reason that these types of cleanups (or even re-formatting the entire codebase) are not performed often is that it "invalidates" any currently-in-progress patch-se= ts. As a result, more work is required from many contributors to rebase useful features due to across-the-board white-space cleanups. Just expressing concern that we need to think carefully about the impacts of such a patch. Regards, -Harry