From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 67491137C for ; Tue, 29 Aug 2017 15:17:23 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 29 Aug 2017 06:17:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,444,1498546800"; d="scan'208";a="143224074" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 29 Aug 2017 06:17:21 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by IRSMSX101.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Tue, 29 Aug 2017 14:17:20 +0100 From: "Van Haaren, Harry" To: Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API. Thread-Index: AQHTHCIRejLk4K1hBEGkGqXEqpO/LKKZoOZA///444CAADSUsIAAB/qAgAASpED///akAIABQoHQ Date: Tue, 29 Aug 2017 13:17:18 +0000 Message-ID: References: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com> <20170828113302.GA22141@PBHAGAVATULA-LT> <20170828150946.GA18980@PBHAGAVATULA-LT> <20170828154259.GA20482@PBHAGAVATULA-LT> In-Reply-To: <20170828154259.GA20482@PBHAGAVATULA-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODIyYzBkZTctNTY1NC00YmU4LWE2M2UtMWFiZmMxMDVlYzdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikg3cWtad1BqU1dlTUk4OHpvREd4NDhhYnJxKytyUE9md1ZEUHVMRENJekU9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 13:17:25 -0000 > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com= ] > Sent: Monday, August 28, 2017 4:43 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcor= e` API. >=20 > On Mon, Aug 28, 2017 at 03:24:06PM +0000, Van Haaren, Harry wrote: > > > > > > > -----Original Message----- > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks= .com] > > > Sent: Monday, August 28, 2017 4:10 PM > > > To: Van Haaren, Harry > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_= lcore` API. > > > > > > On Mon, Aug 28, 2017 at 01:49:37PM +0000, Van Haaren, Harry wrote: > > > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetw= orks.com] > > > > > Sent: Monday, August 28, 2017 12:33 PM > > > > > To: Van Haaren, Harry > > > > > Cc: dev@dpdk.org > > > > > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_serv= ice_lcore` API. > > > > > > > > > > On Mon, Aug 28, 2017 at 10:59:51AM +0000, Van Haaren, Harry wrote= : > > > > > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com= ] > > > > > > > Sent: Wednesday, August 23, 2017 4:10 PM > > > > > > > To: dev@dpdk.org > > > > > > > Cc: Van Haaren, Harry ; Pavan Nik= hilesh > > > > > > > > > > > > > > Subject: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_serv= ice_lcore` API. > > > > > > > > > > > > > > This API can be used to test if an lcore(EAL thread) is a ser= vice lcore. > > > > > > > > > > > > > > Signed-off-by: Pavan Nikhilesh > > > > > > > --- > > > > > > > lib/librte_eal/common/include/rte_lcore.h | 18 +++++++++++++= +++++ > > > > > > > 1 file changed, 18 insertions(+) > > > > > > > > > > > > > > diff --git a/lib/librte_eal/common/include/rte_lcore.h > > > > > > > b/lib/librte_eal/common/include/rte_lcore.h > > > > > > > index 50e0d0f..7854ea1 100644 > > > > > > > --- a/lib/librte_eal/common/include/rte_lcore.h > > > > > > > +++ b/lib/librte_eal/common/include/rte_lcore.h > > > > > > > @@ -180,6 +180,24 @@ rte_lcore_is_enabled(unsigned lcore_id) > > > > > > > } > > > > > > > > > > > > > > /** > > > > > > > + * Test if an lcore is service lcore. > > > > > > > + * > > > > > > > + * @param lcore_id > > > > > > > + * The identifier of the lcore, which MUST be between 0 an= d > > > > > > > + * RTE_MAX_LCORE-1. > > > > > > > + * @return > > > > > > > + * True if the given lcore is service; false otherwise. > > > > > > > + */ > > > > > > > +static inline int > > > > > > > +rte_lcore_is_service_lcore(unsigned lcore_id) > > > > > > > +{ > > > > > > > + struct rte_config *cfg =3D rte_eal_get_configuration(); > > > > > > > + if (lcore_id >=3D RTE_MAX_LCORE) > > > > > > > + return 0; > > > > > > > + return cfg->lcore_role[lcore_id] =3D=3D ROLE_SERVICE; > > > > > > > +} > > > > > > > > > > > > No header file and Static inline - so this is only to be used i= nternally in the > service > > > > > cores library? > > > > > > If so, the function should actually be used, instead of only ad= ded but not used in > the > > > > > library itself. > > > > > > > > > > > > > > > > The enum rte_lcore_role_t has ROLE_SERVICE which tells that a par= ticular lcore is > > > > > a service lcore as well as an EAL thread some libraries such as r= te_timer allow > > > > > specific operations only over EAL threads. > > > > > > > > Understood that role of cores is important, and that rte_timer migh= t require this > > > information. > > > > > > > > > > > > > The rte_timer lib uses the rte_is_lcore_enabled() call to check i= f a lcore is an > > > > > EAL thread, Which checks if the lcore role is ROLE_RTE. But it s= hould also > > > > > allow timers to be registered on a service core as processing tho= se timers can > > > > > be done on them. > > > > > > > > No problem from me here either - although it's the Timers library m= aintainer that should > > > check this. > > > > > > > > > > > > > This new function allows such libraries to check if the role is > > > > > ROLE_SERVICE and allow those operations. > > > > > > > > If the timers library requires information about service-cores, it = should use a public > API > > > to retrieve that information. Having "internal" functions between lib= raries is not nice. > > > > > > > > I think a better design would be to add this function as a public f= unction, (add it to > the > > > .map files etc) and then call the public function from the timers lib= rary. > > > > > > > > Does that sound like a good solution? -Harry > > > > > > > > > > The file rte_lcore.h is in librte_eal/common/include I couldn't find = a .map > > > file for eal/common and also other functions that are present in rte_= lcore.h > > > aren't mapped in eal/linuxapp or eal/bsdapp. > > > I think it is fine as the functions are static inline. > > > > > > -Pavan > > > > OK - I was looking at this from a service core library POV. The intent = seems to be to update > EAL in order to allow detection of a core having a ROLE_SERVICE. Now I se= e your intent better, > no problem with the approach. Correct that static-inline functions don't = need .map file > entries (cause they're inlined :) > > > > One technical issue: > > > + if (lcore_id >=3D RTE_MAX_LCORE) > > > + return 0; > > > > This should return a -ERROR value, as 0 is a valid return value that sh= ould indicate one > thing (and one thing only) "not a service core". >=20 > The function function follows the same structure as rte_lcore_is_enabled = i.e. > returns either true(1) or false(0). So, I think returning 0 would be fine= ?. If > not I'll gladly send a v2. I looked that that function too - I'm not sure what's better API design... Lets stay consistent with other functions in the file; so keep your current= implementation. Note that these service core patches depend on the Service Cores rework pat= chset (currently v2 available here: http://dpdk.org/dev/patchwork/patch/27684/ ) @Pavan, if you have time to Ack the patches this one is based on that would= be fantastic. Acked-by: Harry van Haaren