From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 38FD426A8 for ; Fri, 8 Sep 2017 18:03:22 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 09:03:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,362,1500966000"; d="scan'208";a="1012434617" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 08 Sep 2017 09:03:17 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Fri, 8 Sep 2017 17:03:17 +0100 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds Thread-Index: AQHTIwuui9ipfC6STkWvEMh7L9Xqv6KrMJmQ Date: Fri, 8 Sep 2017 16:03:16 +0000 Message-ID: References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-2-bruce.richardson@intel.com> In-Reply-To: <20170901100416.80264-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGZkMjk5ODItODVkOC00YTZkLWJjOGEtZDJhZDgxZWI1YWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImExWW1aazVQUk5SekNVbDJmOFhhRDJNb3ZRbUhmSkFJcHJoYmlOaUFZcW89In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 16:03:23 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, September 1, 2017 11:04 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for m= eson & > ninja builds > diff --git a/config/meson.build b/config/meson.build > +# set the machine type and cflags for it > +machine =3D get_option('machine') > +dpdk_conf.set('RTE_MACHINE', machine) > +add_project_arguments('-march=3D@0@'.format(machine), language: 'c') > +# some libs depend on maths lib > +add_project_link_arguments('-lm', language: 'c') > + > +# add -include rte_config to cflags > +add_project_arguments('-include', 'rte_config.h', language: 'c') > + > +# disable any unwanted warnings > +unwanted_warnings =3D [ > + '-Wno-address-of-packed-member', > + '-Wno-format-truncation' > +] Feedback from usage while developing new features; - Mis-matched integer sign comparison doesn't cause a warning - And -Werror isn't set by default Adding these as per below fixes things... but for cleanliness "unwanted war= nings" should probably be renamed, we want more warnings! :D # disable any unwanted warnings unwanted_warnings =3D [ '-Werror', '-Wno-address-of-packed-member', '-Wno-format-truncation', '-Wsign-compare', ] The performance of Ninja is amazing for testing shared-object builds and ve= rsion.map changes - feedback is instant. Makes light work of re-checking AB= I/API stuff. > +foreach arg: unwanted_warnings > + if cc.has_argument(arg) > + add_project_arguments(arg, language: 'c') > + endif > +endforeach > +