From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6879956A1 for ; Tue, 12 Sep 2017 10:07:19 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 01:07:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,382,1500966000"; d="scan'208";a="148181914" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga005.jf.intel.com with ESMTP; 12 Sep 2017 01:07:17 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by IRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0319.002; Tue, 12 Sep 2017 09:07:16 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 4/4] eventdev: add device started attribute Thread-Index: AQHTKLhPEUfMX9TVnUWvL1HBcGP1d6Kv61SAgAD/KiA= Date: Tue, 12 Sep 2017 08:07:15 +0000 Message-ID: References: <1504883894-43451-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-5-git-send-email-harry.van.haaren@intel.com> <20170911175242.GB26002@jerin> In-Reply-To: <20170911175242.GB26002@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzdmOTdjMmUtYTk0ZS00ZDc2LTk4YjgtZGU5OTdjMTBkODI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9LNDk4dlRlSFlRaG55S2hxcVJVT2tLS1wvZGVUTFpEWU1TbnNydFhtdkp3PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] eventdev: add device started attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 08:07:19 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, September 11, 2017 6:53 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] eventdev: add device started attribute >=20 > -----Original Message----- > > Date: Fri, 8 Sep 2017 16:36:55 +0100 > > From: Harry van Haaren > > To: dev@dpdk.org > > CC: jerin.jacob@caviumnetworks.com, Harry van Haaren > > > > Subject: [PATCH v3 4/4] eventdev: add device started attribute > > X-Mailer: git-send-email 2.7.4 > > > > This commit adds an attribute to the eventdev, allowing applications > > to retrieve if the eventdev is running or stopped. Note that no API > > or ABI changes were required in adding the statistic, and code changes > > are minimal. > > > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_eventdev/rte_eventdev.c | 3 +++ > > lib/librte_eventdev/rte_eventdev.h | 4 ++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > > index 3756ec7..87a1e19 100644 > > --- a/lib/librte_eventdev/rte_eventdev.c > > +++ b/lib/librte_eventdev/rte_eventdev.c > > @@ -740,6 +740,9 @@ rte_event_dev_attr_get(uint8_t dev_id, uint32_t att= r_id, >=20 > I think, the new rte_event_dev_attr_get function, we can move up so that > all device specific functions comes back to back in API documentation. >=20 > Check the output of "make doc-api-html" >=20 > Other than that, it looks good. > > Acked-by: Jerin Jacob Thanks for the review - all comments make sense. Will respin with comments = addressed, and include Acks.