Re: [dpdk-dev] [PATCH] cmdline: fix warning for unused return value

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, September 7, 2017 2:09 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [dpdk-dev] [PATCH] cmdline: fix warning for unused return value
> 
> When DPDK is compiled on Ubuntu with extra warnings turned on, there is a
> warning about the return value from write() being unchecked. Rather than
> having builds disable the warning, which may mask other cases we do care
> about, we can add a dummy use of the return value in the code to silence it
> in this instance.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

A pragmatic fix for the compile warning at hand;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


>  lib/librte_cmdline/cmdline.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
> index a9c47be..d749165 100644
> --- a/lib/librte_cmdline/cmdline.c
> +++ b/lib/librte_cmdline/cmdline.c
> @@ -205,7 +205,8 @@ cmdline_printf(const struct cmdline *cl, const char *fmt,
> ...)
>  	}
>  	if (ret >= BUFSIZ)
>  		ret = BUFSIZ - 1;
> -	write(cl->s_out, buf, ret);
> +	ret = write(cl->s_out, buf, ret);
> +	(void)ret;
>  	free(buf);
>  #endif
>  }
> --
> 2.7.4