* [dpdk-dev] [PATCH] service: fix compilation error @ 2017-09-20 8:31 Yi Yang 2017-09-20 9:00 ` Van Haaren, Harry 0 siblings, 1 reply; 3+ messages in thread From: Yi Yang @ 2017-09-20 8:31 UTC (permalink / raw) To: harry.van.haaren; +Cc: dev, Yi Yang CC rte_service.o ./dpdk/lib/librte_eal/common/rte_service.c: In function ‘rte_service_start_with_defaults’: ./dpdk/lib/librte_eal/common/rte_service.c:449:9: error: ‘ids[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1); cc1: all warnings being treated as errors ./dpdk/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_service.o' failed Signed-off-by: Yi Yang <yi.y.yang@intel.com> --- lib/librte_eal/common/rte_service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 43716bb..e598e16 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -431,7 +431,7 @@ rte_service_start_with_defaults(void) uint32_t count = rte_service_get_count(); int32_t lcore_iter = 0; - uint32_t ids[RTE_MAX_LCORE]; + uint32_t ids[RTE_MAX_LCORE] = {0}; int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE); if (lcore_count == 0) -- 2.1.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] service: fix compilation error 2017-09-20 8:31 [dpdk-dev] [PATCH] service: fix compilation error Yi Yang @ 2017-09-20 9:00 ` Van Haaren, Harry 2017-09-21 1:50 ` Yang, Yi 0 siblings, 1 reply; 3+ messages in thread From: Van Haaren, Harry @ 2017-09-20 9:00 UTC (permalink / raw) To: Yang, Yi Y; +Cc: dev > From: Yang, Yi Y > Sent: Wednesday, September 20, 2017 9:31 AM > To: Van Haaren, Harry <harry.van.haaren@intel.com> > Cc: dev@dpdk.org; Yang, Yi Y <yi.y.yang@intel.com> > Subject: [PATCH] service: fix compilation error > > CC rte_service.o > ./dpdk/lib/librte_eal/common/rte_service.c: In function > ‘rte_service_start_with_defaults’: > ./dpdk/lib/librte_eal/common/rte_service.c:449:9: > error: ‘ids[0]’ may be used uninitialized in this > function [-Werror=maybe-uninitialized] > ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1); > > cc1: all warnings being treated as errors > ./dpdk/mk/internal/rte.compile-pre.mk:138: > recipe for target 'rte_service.o' failed > > Signed-off-by: Yi Yang <yi.y.yang@intel.com> Hi Yi, Would you provide a more descriptive commit title and message please? The compilation output should not be included in the commit message, instead a short description of what the error is, and what steps can be taken to reproduce the error are much more helpful. The code changes look OK to me - but I'd like to be able to catch these issues in future, so steps to reproduce are valuable to me. Thanks, -Harry > --- > lib/librte_eal/common/rte_service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/rte_service.c > b/lib/librte_eal/common/rte_service.c > index 43716bb..e598e16 100644 > --- a/lib/librte_eal/common/rte_service.c > +++ b/lib/librte_eal/common/rte_service.c > @@ -431,7 +431,7 @@ rte_service_start_with_defaults(void) > uint32_t count = rte_service_get_count(); > > int32_t lcore_iter = 0; > - uint32_t ids[RTE_MAX_LCORE]; > + uint32_t ids[RTE_MAX_LCORE] = {0}; > int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE); > > if (lcore_count == 0) > -- > 2.1.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] service: fix compilation error 2017-09-20 9:00 ` Van Haaren, Harry @ 2017-09-21 1:50 ` Yang, Yi 0 siblings, 0 replies; 3+ messages in thread From: Yang, Yi @ 2017-09-21 1:50 UTC (permalink / raw) To: Van Haaren, Harry; +Cc: dev On Wed, Sep 20, 2017 at 05:00:11PM +0800, Van Haaren, Harry wrote: > > From: Yang, Yi Y > > Sent: Wednesday, September 20, 2017 9:31 AM > > To: Van Haaren, Harry <harry.van.haaren@intel.com> > > Cc: dev@dpdk.org; Yang, Yi Y <yi.y.yang@intel.com> > > Subject: [PATCH] service: fix compilation error > > > > CC rte_service.o > > ./dpdk/lib/librte_eal/common/rte_service.c: In function > > ‘rte_service_start_with_defaults’: > > ./dpdk/lib/librte_eal/common/rte_service.c:449:9: > > error: ‘ids[0]’ may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > > ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1); > > > > cc1: all warnings being treated as errors > > ./dpdk/mk/internal/rte.compile-pre.mk:138: > > recipe for target 'rte_service.o' failed > > > > Signed-off-by: Yi Yang <yi.y.yang@intel.com> > > Hi Yi, > > Would you provide a more descriptive commit title > and message please? The compilation output should not be > included in the commit message, instead a short description > of what the error is, and what steps can be taken to > reproduce the error are much more helpful. > > The code changes look OK to me - but I'd like to be able > to catch these issues in future, so steps to reproduce are > valuable to me. > > Thanks, -Harry Harry, normal DPDK make everybody does usually will trigger this on current master tree, I'm not sure if it is gcc version related. On my Fedora 21, it can be reproduced very easily. I met it when I fixed another vhost bug, I can't build DPDK without it, that is why I want to commit it to you :-) I have posted out v2 with more descriptive title and git log body per your comments. Thanks a lot for your review. > > > > --- > > lib/librte_eal/common/rte_service.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/common/rte_service.c > > b/lib/librte_eal/common/rte_service.c > > index 43716bb..e598e16 100644 > > --- a/lib/librte_eal/common/rte_service.c > > +++ b/lib/librte_eal/common/rte_service.c > > @@ -431,7 +431,7 @@ rte_service_start_with_defaults(void) > > uint32_t count = rte_service_get_count(); > > > > int32_t lcore_iter = 0; > > - uint32_t ids[RTE_MAX_LCORE]; > > + uint32_t ids[RTE_MAX_LCORE] = {0}; > > int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE); > > > > if (lcore_count == 0) > > -- > > 2.1.0 > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-21 2:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-20 8:31 [dpdk-dev] [PATCH] service: fix compilation error Yi Yang 2017-09-20 9:00 ` Van Haaren, Harry 2017-09-21 1:50 ` Yang, Yi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).