From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4B79E1B628 for ; Wed, 18 Oct 2017 11:13:46 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 02:13:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,395,1503385200"; d="scan'208";a="161801207" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2017 02:13:44 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0319.002; Wed, 18 Oct 2017 10:13:44 +0100 From: "Van Haaren, Harry" To: "Mcnamara, John" , "Yang, Zhiyong" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Yang, Zhiyong" Thread-Topic: [dpdk-dev] [PATCH 8/8] doc: update port id type Thread-Index: AQHTRCXZvwX1nyx3y02iiiBecjs5LaLh2l8AgAd/s+A= Date: Wed, 18 Oct 2017 09:13:43 +0000 Message-ID: References: <20171013131701.38147-1-zhiyong.yang@intel.com> <20171013131701.38147-9-zhiyong.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWU0ZGVmZjktYTg0ZC00YTEzLTk0MDYtZmZmZTcyOTcyODBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1aaW1keHVNVUpLQjhPSXhVOGlKUFl3amZ3Q1NlVUpBS2VpRFFONTB2Ykk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 8/8] doc: update port id type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 09:13:47 -0000 > From: Mcnamara, John > Sent: Friday, October 13, 2017 4:41 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > ; Van Haaren, Harry > Subject: RE: [dpdk-dev] [PATCH 8/8] doc: update port id type >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang > > Sent: Friday, October 13, 2017 2:17 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Yang, Zhiyong > > > > Subject: [dpdk-dev] [PATCH 8/8] doc: update port id type > > > > Since port id has changed from uint8_t to uint16_t in dpdk code, So upd= ate > > the change in related doc. > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > Signed-off-by: Zhiyong Yang >=20 > Looks good. There is one other unchanged reference but I don't know if it= is > relevant. >=20 > CC: Harry >=20 > $ ag "uint8_t port" doc/guides/ > doc/guides/prog_guide/eventdev.rst > 283: uint8_t port_id =3D 0; No need to change this in the docs - the port here is an Eventdev port, not= an Ethdev port. TL:DR; Looks good to me! -Harry