From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 944E51B1B8
 for <dev@dpdk.org>; Fri, 20 Oct 2017 12:22:01 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 20 Oct 2017 03:22:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,405,1503385200"; d="scan'208";a="325561421"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2017 03:21:58 -0700
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
 IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 20 Oct 2017 11:21:58 +0100
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by
 irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002;
 Fri, 20 Oct 2017 11:21:58 +0100
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id
Thread-Index: AQHTREGQQrsF/wlYT0uzegXVGZ1aJaLskbKg
Date: Fri, 20 Oct 2017 10:21:57 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FC926D@IRSMSX102.ger.corp.intel.com>
References: <1507712990-13064-1-git-send-email-pbhagavatula@caviumnetworks.com>
 <1507912610-14409-1-git-send-email-pbhagavatula@caviumnetworks.com>
In-Reply-To: <1507912610-14409-1-git-send-email-pbhagavatula@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjdmODUyZjQtNDNhZS00ZDNiLWI1YTQtODI4NGQzMzU0YWZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IngxTEdrd3Njd3RpeWpYKzBRWWRlR1pRTEdpOElHNjlaNXpDV2VISGcyakE9In0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2017 10:22:02 -0000

> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Friday, October 13, 2017 5:37 PM
> To: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id
>=20
> From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
>=20
> In case of sw event device the scheduling can be done on a service core
> using the service registered at the time of probe.
> This patch adds a helper function to get the service id that can be used
> by the application to assign a lcore for the service to run on.
>=20
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

<snip>

>   * Dump internal information about *dev_id* to the FILE* provided in *f*=
.
>   *
>   * @param dev_id
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map
> b/lib/librte_eventdev/rte_eventdev_version.map
> index d555b19..59c36a0 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -53,6 +53,7 @@ DPDK_17.11 {
>  	rte_event_dev_attr_get;
>  	rte_event_port_attr_get;
>  	rte_event_queue_attr_get;
> +	rte_event_dev_service_id_get;


Version-map diff didn't apply cleanly - probably better fixed on apply;
Also, I think the functions are supposed to be in alphabetical order.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>