From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1BFAD1B91F for ; Wed, 25 Oct 2017 15:43:11 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2017 06:43:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,431,1503385200"; d="scan'208";a="327551180" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 25 Oct 2017 06:43:09 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Wed, 25 Oct 2017 14:43:08 +0100 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "hemant.agrawal@nxp.com" , "jerin.jacob@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get function Thread-Index: AQHTTCYpeyiqhBR3DEmeE4ArEwyEqaL0lKiA Date: Wed, 25 Oct 2017 13:43:08 +0000 Message-ID: References: <1507814147-8223-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508780456-27837-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508780456-27837-2-git-send-email-pbhagavatula@caviumnetworks.com> In-Reply-To: <1508780456-27837-2-git-send-email-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzQ2ZmI5MGMtNzlmNS00ZDI0LWI0MzktYWYyOTVjZjRkYzkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdudjVMN01ueHdKSkJ1ZG1sXC80a1wvXC9Wbng0QVM3Z29jUjc4WWRza0hyd3c9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 13:43:12 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Monday, October 23, 2017 6:41 PM > To: Van Haaren, Harry ; hemant.agrawal@nxp.co= m; > jerin.jacob@caviumnetworks.com > Cc: dev@dpdk.org; Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get > function >=20 > From: Pavan Bhagavatula >=20 > Add schedule type queue attribute so that it can be queried along with > the queue config structure. >=20 > Signed-off-by: Pavan Nikhilesh > --- >=20 > v2 changes: > - return EOVERFLOW when schedule_type is requested and event_queue_cfg = is > set > to *ALL_TYPES*. >=20 > lib/librte_eventdev/rte_eventdev.c | 6 ++++++ > lib/librte_eventdev/rte_eventdev.h | 7 +++++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > index db96552..fa18422 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -809,6 +809,12 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t > queue_id, uint32_t attr_id, > case RTE_EVENT_QUEUE_ATTR_EVENT_QUEUE_CFG: > *attr_value =3D conf->event_queue_cfg; > break; > + case RTE_EVENT_QUEUE_ATTR_SCHEDULE_TYPE: > + if (conf->event_queue_cfg =3D=3D RTE_EVENT_QUEUE_CFG_ALL_TYPES) > + return -EOVERFLOW; I think event_queue_cfg is a bit-set right? The =3D=3D on this line above i= s a bug in that case, should be & With above comments; Acked-by: Harry van Haaren