From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 27992324B for ; Tue, 19 Dec 2017 13:00:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 04:00:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="13561097" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 19 Dec 2017 04:00:03 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Tue, 19 Dec 2017 12:00:03 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "Eads, Gage" , "jerin.jacobkollanukkaran@cavium.com" , "Rao, Nikhil" , "hemant.agrawal@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline Thread-Index: AQHTb5tuO/vf7dk6zkqnoU1UmalVhaNKoPiQ Date: Tue, 19 Dec 2017 12:00:02 +0000 Message-ID: References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-8-pbhagavatula@caviumnetworks.com> In-Reply-To: <20171207203705.25020-8-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWY2ZDg2NGEtZTcwMi00ZjAwLWJkZjEtMmNlODFkODczOWM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5DbE9vWERzT0tMVnhNTDg4SWdpR2NTaFF2UXo4Q1wvSFh6Z3BTM0E0cXc4PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 12:00:07 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Thursday, December 7, 2017 8:37 PM > To: Eads, Gage ; jerin.jacobkollanukkaran@cavium.com= ; > Van Haaren, Harry ; Rao, Nikhil > ; hemant.agrawal@nxp.com; Ma, Liang J > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipel= ine >=20 > Add worker pipeline when Tx is multi thread safe. > Probe Ethernet dev capabilities and select it it is supported. >=20 > Signed-off-by: Pavan Nikhilesh > static void > diff --git a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > index a5837c99b..0b27d1eb0 100644 > --- a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > +++ b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > @@ -108,6 +108,7 @@ struct config_data { > int dump_dev_signal; > unsigned int num_stages; > unsigned int worker_cq_depth; > + unsigned int rx_stride; Perhaps comment what "rx stride" does? The others variables are logical eno= ugh to me, but this one I don't get..=20 > +static int > +setup_eventdev_w(struct prod_data *prod_data, > + struct cons_data *cons_data, > + struct worker_data *worker_data) I think this function name can be improved - what does the w mean?