From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C24FC3237 for ; Tue, 19 Dec 2017 16:27:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 07:27:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,427,1508828400"; d="scan'208";a="188105719" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 19 Dec 2017 07:27:27 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0319.002; Tue, 19 Dec 2017 15:27:26 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest Thread-Index: AQHTdOywDELxalBkJEib/S9wIagAFaNK0KCQ Date: Tue, 19 Dec 2017 15:27:25 +0000 Message-ID: References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-11-pbhagavatula@caviumnetworks.com> In-Reply-To: <20171214150138.25667-11-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQxYjM4NDAtNTEzYi00Y2U1LWIxOGMtYTM3NzFhNGI2ZDU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilp0MFwvbVFvRHNBSDlMVndLR21cL3hQa1FzWjNLWFpmZFhBVkc3SGpDbGtjYz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 15:27:31 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Thursday, December 14, 2017 3:02 PM > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; > Richardson, Bruce ; Van Haaren, Harry > ; Eads, Gage ; > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > [Side note: we shouldn't put everybody on CC all the time..] > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest >=20 > Signed-off-by: Pavan Nikhilesh > diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c > index 1ed2a1ddd..b86efab01 100644 > --- a/test/test/test_eventdev.c > +++ b/test/test/test_eventdev.c > @@ -1009,4 +1009,11 @@ test_eventdev_common(void) > return unit_test_suite_runner(&eventdev_common_testsuite); > } >=20 > +static int > +test_eventdev_selftest(void) > +{ > + return rte_event_dev_selftest(TEST_DEV_ID); > +} > + > REGISTER_TEST_COMMAND(eventdev_common_autotest, test_eventdev_common); > +REGISTER_TEST_COMMAND(eventdev_selftest, test_eventdev_selftest); Currently when running the test app, we don't pass any arguments. Running t= he "eventdev_sw_autotest" command, it will create the required event_sw0 PM= D vdev, and launch the tests then. Given the selftest is PMD agnostic, does it makes sense to have a single st= ring "sw" or "octeontx" to run the tests against? Right now it requires tha= t we pass ./app/test --vdev event_sw0 which I think is a burden, particula= rly when automating this with the meson test infrastructure down the line. Summary; Please add a string parameter that indicates the PMD to run the se= lf-test on.