From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 05C9A1B235 for ; Thu, 21 Dec 2017 11:48:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 02:48:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="160682037" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 21 Dec 2017 02:48:39 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 10:48:22 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Thu, 21 Dec 2017 10:48:22 +0000 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH 2/2] test/test: add return value to mark unit tests as skipped Thread-Index: AQHTekSsB9qz/FwkyUap+D1GuuHQ9KNNlsiAgAAG1cA= Date: Thu, 21 Dec 2017 10:48:22 +0000 Message-ID: References: <20171221101510.181082-1-bruce.richardson@intel.com> <20171221101510.181082-3-bruce.richardson@intel.com> <20171221102253.GA11720@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20171221102253.GA11720@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk3ZTE3ZTUtODg2MS00N2QwLTk0MDUtNDkzNjdhMzlkNWJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5YMXVpQXlYY3FuU3dlcEx3WHNXZEFRWU5mTXVIWVZZcVoySVFSd2NyN289In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 10:48:41 -0000 > From: Richardson, Bruce > Sent: Thursday, December 21, 2017 10:23 AM > To: dev@dpdk.org; Doherty, Declan ; De Lara > Guarch, Pablo > Cc: Van Haaren, Harry > Subject: Re: [PATCH 2/2] test/test: add return value to mark unit tests a= s > skipped >=20 > On Thu, Dec 21, 2017 at 10:15:10AM +0000, Bruce Richardson wrote: > > Add in a TEST_SKIPPED return value for unit tests to mark the tests > > as skipped, rather than just failed. Use this new skipped return value = for > > the crypto tests which can only run if they have a particular driver. > > > > Signed-off-by: Bruce Richardson > > +Declan and Pablo as maintainers of crypto code. Looks good to me, checked unit tests using old build system and binary, but= 2nd Ack from crypto maintainers welcome :) Acked-by: Harry van Haaren