From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Eads, Gage" <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"pbhagavatula@caviumnetworks.com"
<pbhagavatula@caviumnetworks.com>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH] event/sw: remove stale IQ references when reconfigured
Date: Tue, 9 Jan 2018 17:29:45 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FEC1A3@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1515514775-10859-1-git-send-email-gage.eads@intel.com>
> From: Eads, Gage
> Sent: Tuesday, January 9, 2018 4:20 PM
> To: dev@dpdk.org
> Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; pbhagavatula@caviumnetworks.com;
> santosh.shukla@caviumnetworks.com
> Subject: [PATCH] event/sw: remove stale IQ references when reconfigured
>
> This commit fixes a bug in which, when the sw PMD is reconfigured, it would
> leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD
> initializes all IQs at eventdev start time and releases all IQ chunk
> pointers at eventdev stop time (which has the consequence that any events
> in a queue when the eventdev is stopped will be lost). This approach should
> be resilient to any reconfiguration done between the stop and start, such
> as adding or removing queues.
>
> This commit also fixes two potential issues in iq_chunk.h. iq_init()
> now initializes the IQ's count field to 0, and iq_dequeue_burst() sets
> iq->head to the appropriate next pointer.
>
> Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs")
> Signed-off-by: Gage Eads <gage.eads@intel.com>
After reproducing the error reliably, I can confirm this patch fixes here.
Also, I think this patch deserves a reported by tag. Perhaps it can be added on apply?
Reported-By: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
@Pavan, as the reporter, would you double check please?
With a +1 / Ack from Pavan, lets merge this :)
Reviewed-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2018-01-09 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:19 Gage Eads
2018-01-09 17:29 ` Van Haaren, Harry [this message]
2018-01-10 10:26 ` Pavan Nikhilesh
2018-01-10 19:00 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA650FEC1A3@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).