From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5F1841B1BB for ; Tue, 9 Jan 2018 18:29:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 09:29:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="193607270" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2018 09:29:46 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 17:29:45 +0000 From: "Van Haaren, Harry" To: "Eads, Gage" , "dev@dpdk.org" CC: "jerin.jacob@caviumnetworks.com" , "pbhagavatula@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" Thread-Topic: [PATCH] event/sw: remove stale IQ references when reconfigured Thread-Index: AQHTiWWvIymluR+erEiUvyh6XUJwv6Nryo8Q Date: Tue, 9 Jan 2018 17:29:45 +0000 Message-ID: References: <1515514775-10859-1-git-send-email-gage.eads@intel.com> In-Reply-To: <1515514775-10859-1-git-send-email-gage.eads@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODYzZjUyZTUtNDQzYy00ZmZmLThhZWMtNzA3YmMyZWMyZjYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkxSdmFBT1wvNUxRc3pyMkFIclA4ZllwYWE4ZnJEWWw0azZBOTFUMnhCXC9Vbz0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] event/sw: remove stale IQ references when reconfigured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 17:29:48 -0000 > From: Eads, Gage > Sent: Tuesday, January 9, 2018 4:20 PM > To: dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > ; pbhagavatula@caviumnetworks.com; > santosh.shukla@caviumnetworks.com > Subject: [PATCH] event/sw: remove stale IQ references when reconfigured >=20 > This commit fixes a bug in which, when the sw PMD is reconfigured, it wou= ld > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD > initializes all IQs at eventdev start time and releases all IQ chunk > pointers at eventdev stop time (which has the consequence that any events > in a queue when the eventdev is stopped will be lost). This approach shou= ld > be resilient to any reconfiguration done between the stop and start, such > as adding or removing queues. >=20 > This commit also fixes two potential issues in iq_chunk.h. iq_init() > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets > iq->head to the appropriate next pointer. >=20 > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs") > Signed-off-by: Gage Eads After reproducing the error reliably, I can confirm this patch fixes here. Also, I think this patch deserves a reported by tag. Perhaps it can be adde= d on apply? Reported-By: Pavan Nikhilesh @Pavan, as the reporter, would you double check please? With a +1 / Ack from Pavan, lets merge this :) Reviewed-by: Harry van Haaren