From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 742522A63 for ; Tue, 16 Jan 2018 12:57:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 03:57:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,368,1511856000"; d="scan'208";a="10936157" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga006.jf.intel.com with ESMTP; 16 Jan 2018 03:57:29 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX109.ger.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0319.002; Tue, 16 Jan 2018 11:57:28 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 07/13] app/eventdev: add Tx service setup Thread-Index: AQHTi8TB+8WmvWYPXUSJsKvh5IW2DaN2YGsQ Date: Tue, 16 Jan 2018 11:57:28 +0000 Message-ID: References: <20171130072406.15605-1-pbhagavatula@caviumnetworks.com> <20180112164416.21374-1-pbhagavatula@caviumnetworks.com> <20180112164416.21374-7-pbhagavatula@caviumnetworks.com> In-Reply-To: <20180112164416.21374-7-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjVjNWNlOTYtNmY3My00NWRjLThlYTktNjJlOTk1ZTc5ZGVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVFaFR2SkZ3THdwRUhubjJCVDkwQkNPVnRPOWY5cXoxNWllQWdnbXJkVGM9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 07/13] app/eventdev: add Tx service setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 11:57:32 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Friday, January 12, 2018 4:44 PM > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; Va= n > Haaren, Harry ; Eads, Gage > ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, > Liang J > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 07/13] app/eventdev: add Tx service setup >=20 > Setup one port event port for Tx and link the respective event queue. > Register the Tx function as a service to be called from a service core. > The Tx function dequeues the events from the event queue and transmits > the packet to its respective ethernet port. >=20 > Signed-off-by: Pavan Nikhilesh Just a comment below - no changes required. Acked-by: Harry van Haaren > +int > +pipeline_event_tx_service_setup(struct evt_test *test, struct evt_option= s > *opt, > + uint8_t tx_queue_id, uint8_t tx_port_id, > + const struct rte_event_port_conf p_conf) > +{ > + /* Register Tx service */ > + memset(&serv, 0, sizeof(struct rte_service_spec)); > + snprintf(serv.name, sizeof(serv.name), "Tx_service"); > + > + if (evt_has_burst_mode(opt->dev_id)) > + serv.callback =3D pipeline_event_tx_burst_service_func; > + else > + serv.callback =3D pipeline_event_tx_service_func; > + > + serv.callback_userdata =3D (void *)tx; > + ret =3D rte_service_component_register(&serv, &tx->service_id); > + if (ret) { > + evt_err("failed to register Tx service"); > + return ret; > + } > + > + ret =3D evt_service_setup(tx->service_id); > + if (ret) { > + evt_err("Failed to setup service core for Tx service\n"); > + return ret; > + } > + > + rte_service_runstate_set(tx->service_id, 1); It looks like the code above never sets the "component runstate" to indicat= e that the TX service itself is in a runnable state. This setting of the runstate is performed later in the setup process, when = launching cores.