From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3D64B1B650 for ; Fri, 26 Jan 2018 11:10:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 02:10:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="25631777" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 26 Jan 2018 02:10:24 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX103.ger.corp.intel.com ([169.254.3.197]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 10:10:23 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "Varghese, Vipin" Thread-Topic: [dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init Thread-Index: AQHTiwkDPwHwEGo5Lk+TZGQ7cxqlOaOFPK2AgADIAGA= Date: Fri, 26 Jan 2018 10:10:23 +0000 Message-ID: References: <1514731568-3979-1-git-send-email-vipin.varghese@intel.com> <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> <1706116.QiZev3mjbx@xps> In-Reply-To: <1706116.QiZev3mjbx@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2QyOWFkY2ItMzlmNi00N2MzLWIzY2ItMzRjYWVhN2RlNGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJGR1VGRkcxNENudE5pSTdENW9qaHRUTnhkZ1J0ckZ1b1FRZlBVR21vUzNVMnpNUmtKTjZFSXpQR09pU3hjUTY1In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 10:10:26 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, January 25, 2018 10:11 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Van Haaren, Harry ; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2] service: fix memory leak by > rte_service_init >=20 > 11/01/2018 19:20, Vipin Varghese: > > This patch fixes the memory leak created by rte_service_init. When > > secondary application which shares the huge page from primary, is > > executed multiple times memory is initialized but not freed on exit > > > > The rte_service_finalize checks if the service is initialized. If yes, > > it frees up rte_services & lcore_states. The API has to be called at > > end of application run. > > > > renamed the function from rte_service_deinit to rte_service_finalize. >=20 > This is a changelog. It should appear below --- >=20 > > Signed-off-by: Vipin Varghese >=20 > Why not keeping previous ack? >=20 > Your patches have been set to "Not Applicable" in patchwork. > What happened? There was some confusion in my review-comments, and Vipin and I discussed the best was to rework - I suggested marking the current patches as Not App= licable. Is there a better state to put the patches in Patchwork if we don't want co= mmiters to look at them? Or would an email to the thread stating V+1 in progress be better? A new version will hit the ML soon.