From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3B2021B2D9; Fri, 26 Jan 2018 16:20:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 07:20:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,417,1511856000"; d="scan'208";a="22766285" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jan 2018 07:20:48 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 15:20:47 +0000 From: "Van Haaren, Harry" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3] service: fix memory leak by rte_service_init Thread-Index: AQHTlrhYs5R1pRG+OEOI/OHgKaj4K6OGRGfA Date: Fri, 26 Jan 2018 15:20:47 +0000 Message-ID: References: <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> <1517000136-24802-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1517000136-24802-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjMzZTUwZjgtN2M4OC00MDFhLWExM2MtZTQzNWE0MzE5ZmZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJIZVNqQ1pFbFAwZXdXWmZ4d2w5OCtqTlwveUVROUNBcVl2bVpQZlp5aWJIb3VlK3ArN1lPMUpqa3RtY2xiNmVOeSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 15:20:51 -0000 > From: Varghese, Vipin > Sent: Friday, January 26, 2018 8:56 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: stable@dpdk.org; Varghese, Vipin > Subject: [PATCH v3] service: fix memory leak by rte_service_init >=20 > The rte_service_finalize routine checks if service is initialized > or not. If yes; releases internal memory for services and lcore > states are freed. This routine is to be invoked at end of application > termination. >=20 > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: harry.van.haaren@intel.com >=20 > Signed-off-by: Vipin Varghese Thanks Vipin! @Stable - this patches allows for fixes secondary processes that init and quit often, to avoid leaking hugepages memory. As such, I think it is valuable to include in stable. Acked-by: Harry van Haaren > V2 Changes: > - renamed routine to finalize (Bruce) > - improved code flow (Harry) >=20 > V3 Changes: > - fix order of function in map file