From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1132B1B28E; Fri, 26 Jan 2018 16:44:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 07:44:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,417,1511856000"; d="scan'208";a="25689908" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 26 Jan 2018 07:44:23 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX101.ger.corp.intel.com ([169.254.1.188]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 15:44:22 +0000 From: "Van Haaren, Harry" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] app/procinfo: Fix memory leak by rte_service_init Thread-Index: AQHTixUfAQVsyuRev0ymKG2SnxxjXaOGYrJg Date: Fri, 26 Jan 2018 15:44:22 +0000 Message-ID: References: <1514735641-8738-1-git-send-email-vipin.varghese@intel.com> <1515700054-29654-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1515700054-29654-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhiMGRlNTUtNjdmYi00YjY1LWE1NjktMDZiNGY1NDYyMzkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJaRURwUlNxWm5hbkhWUm1BS0tJTlllN0t0R0Jsck1kTWx1aUR4ekNoeGU2YkRGeDJuYzVTUkNCeGhcL1pRbXZQViJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 15:44:25 -0000 > From: Varghese, Vipin > Sent: Thursday, January 11, 2018 7:48 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: stable@dpdk.org; Varghese, Vipin > Subject: [PATCH v2] app/procinfo: Fix memory leak by rte_service_init >=20 > When procinfo is run multiple times against primary application, it > consumes huge page memory by rte_service_init. Which is not released > at exit of application. >=20 > Invoking rte_service_finalize to real memory and prevent memory leak. >=20 > Signed-off-by: Vipin Varghese Thanks Vipin. Note that this fixes a hugepages memory leak that would otherwise occur when a secondary process initializes EAL and then quits. Note that this patch depends on the patch adding rte_service_finalize() http://dpdk.org/dev/patchwork/patch/34555/ Acked-by: Harry van Haaren