From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F07831B337; Fri, 26 Jan 2018 18:15:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 09:15:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,417,1511856000"; d="scan'208";a="13228535" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 26 Jan 2018 09:15:19 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 17:15:18 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon , "Varghese, Vipin" CC: "stable@dpdk.org" , "dev@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init Thread-Index: AQHTixUfAQVsyuRev0ymKG2SnxxjXaOGd/mAgAAAgjA= Date: Fri, 26 Jan 2018 17:15:17 +0000 Message-ID: References: <1514735641-8738-1-git-send-email-vipin.varghese@intel.com> <1515700054-29654-1-git-send-email-vipin.varghese@intel.com> <1543040.UXSxQDX3pr@xps> In-Reply-To: <1543040.UXSxQDX3pr@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTRhMDY1NTktZWRhOC00NjhhLTk4OGEtODQ0YzlhZTM2Nzk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJtVFJPbm0rNVJyN0FVY04yczRNMHU2c0wrQ0FiaVl1VVF3TnNmRUVYTHVMUzNJQzRJc0V1SmsrenhxSGdZOHQrIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:15:22 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, January 26, 2018 5:00 PM > To: Varghese, Vipin ; Van Haaren, Harry > > Cc: stable@dpdk.org; dev@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by > rte_service_init >=20 > 11/01/2018 20:47, Vipin Varghese: > > When procinfo is run multiple times against primary application, it > > consumes huge page memory by rte_service_init. Which is not released > > at exit of application. > > > > Invoking rte_service_finalize to real memory and prevent memory leak. >=20 > I don't think it is correct to call rte_service_finalize in applications, > while rte_service_init is called in EAL. >=20 > Maybe we need a new function in EAL. Yes correct - we need a rte_eal_deinit(), cleanup() or finalize() or someth= ing. This ties in with splitting EAL to be more modular on startup, and DPD= K in general behaving more like a library and less like a single-monolith. For the 18.02 timeframe, the simplest solution to solve the secondary proce= ss mem-leak issue than to merge into these applications, unfortunately.=20 The only other option I see is to add an rte_eal_finalize() function, and h= ide this call behind it, however it is quite late to add such a function, a= nd what do we do with cases like rte_panic(), rte_exit(), or system signals= like SIGINT, SIGHUP etc? It seems too complicated to add "quickly" to me. If there is technically a better solution viable in the given timeframe, I'= m open to suggestions?