From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <harry.van.haaren@intel.com> Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5A2EF1B6A9 for <dev@dpdk.org>; Mon, 29 Jan 2018 13:12:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 04:12:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="199478316" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2018 04:12:55 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 12:12:54 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by irsmsx112.ger.corp.intel.com ([169.254.1.242]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 12:12:54 +0000 From: "Van Haaren, Harry" <harry.van.haaren@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Varghese, Vipin" <vipin.varghese@intel.com> Thread-Topic: [PATCH v2 2/4] eal: add function to release internal resources Thread-Index: AQHTmO51zNxoE7Ze90Wo+W695Un+8qOKrZ8AgAADZYCAAA1DgIAABFrw Date: Mon, 29 Jan 2018 12:12:53 +0000 Message-ID: <E923DB57A917B54B9182A2E928D00FA651008BBE@IRSMSX102.ger.corp.intel.com> References: <1517077877-53654-1-git-send-email-harry.van.haaren@intel.com> <3800883.jMHuFJQnlm@xps> <E923DB57A917B54B9182A2E928D00FA651008AAE@IRSMSX102.ger.corp.intel.com> <8777922.WAhnjB1RAy@xps> In-Reply-To: <8777922.WAhnjB1RAy@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmJjN2U4MDctZGY0OS00ZTFhLTgzZmMtMzFlZjAyZmE1ZjkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJaRDBSejk2UCt4WHVKYmRPRjdabjFxczhNR3R4eEpjUEtmajZObGh1NW9mQmNaeGN0NFVaclRQejUyblhiMDNaIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] eal: add function to release internal resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 29 Jan 2018 12:12:57 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, January 29, 2018 11:56 AM > To: Van Haaren, Harry <harry.van.haaren@intel.com> > Cc: dev@dpdk.org; Varghese, Vipin <vipin.varghese@intel.com> > Subject: Re: [PATCH v2 2/4] eal: add function to release internal resourc= es >=20 > 29/01/2018 12:10, Van Haaren, Harry: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Monday, January 29, 2018 10:56 AM > > > To: Van Haaren, Harry <harry.van.haaren@intel.com> > > > Cc: dev@dpdk.org; Varghese, Vipin <vipin.varghese@intel.com> > > > Subject: Re: [PATCH v2 2/4] eal: add function to release internal > resources > > > > > > 29/01/2018 11:45, Harry van Haaren: > > > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > > > +Finalizing and Cleanup > > > > +~~~~~~~~~~~~~~~~~~~~~~ > > > > + > > > > +During the initialization of EAL resources such as hugepage backed > memory > > > can be > > > > +allocated by core components. The memory allocated during > > > ``rte_eal_init()`` > > > > +can be released by calling the ``rte_eal_finalize()`` function. Re= fer > to > > > the > > > > +API documentation for details. > > > > > > About naming, what is better between > > > rte_eal_finalize() and > > > rte_eal_cleanup() ? > > > I tend to think that "cleanup" is more descriptive. > > > > Sure cleanup() is fine for me, I'll spin a v3 with the function name > change. >=20 > Harry, it is a real question! Yup, > If someone thinks "finalize" is better, I would like to hear it > because we may use the same wording in more DPDK functions. To me, finalize() and cleanup() mean the same thing. I think cleanup() is a simpler term (and I like simple :) Hence, v3 sent with cleanup()