From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 1655CA84E for ; Tue, 13 Mar 2018 15:08:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 07:08:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,465,1515484800"; d="scan'208";a="38413135" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2018 07:08:20 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.10]) by IRSMSX101.ger.corp.intel.com ([169.254.1.5]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 14:08:20 +0000 From: "Van Haaren, Harry" To: "Eads, Gage" , "dev@dpdk.org" CC: "jerin.jacob@caviumnetworks.com" Thread-Topic: [PATCH v2] event/sw: perform partial burst enqueues Thread-Index: AQHTuhIs8gCAx3jlFkWM1iv9mV/O8qPONOXA Date: Tue, 13 Mar 2018 14:08:20 +0000 Message-ID: References: <1520549742-12893-1-git-send-email-gage.eads@intel.com> <1520866522-13942-1-git-send-email-gage.eads@intel.com> In-Reply-To: <1520866522-13942-1-git-send-email-gage.eads@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBlOTgxMWYtN2E1ZC00ZjBiLTk4NzAtYzA0MmYxZjk4OTc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLamNQOTNhREdzXC9nbWF2KzZ4TjBUazVxRmtaM1Q5RzJaK1wvWWtHU0xRdmFveW5laE9oVHZxWFBDdWhRXC9cLzIzYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] event/sw: perform partial burst enqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 14:08:23 -0000 > From: Eads, Gage > Sent: Monday, March 12, 2018 2:55 PM > To: dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > Subject: [PATCH v2] event/sw: perform partial burst enqueues >=20 > Previously, the sw PMD would enqueue either all or no events, depending o= n > if enough inflight credits were available for the new events in the burst= . > If a port is enqueueing a large burst (i.e. a multiple of the credit upda= te > quanta), this can result in suboptimal performance, and requires an > understanding of the sw PMD implementation (in particular, its credit > scheme) to tune an application's burst size. >=20 > This affects software that enqueues large bursts of new events, such as t= he > ethernet event adapter which uses a 128-deep event buffer, when the input > packet rate is sufficiently high. >=20 > This change makes the sw PMD enqueue as many events as it has credits, if > there are any new events in the burst. >=20 > Signed-off-by: Gage Eads Agree that making forward progress by enqueuing what we have credits for makes sense for the application. No performance degradation here, thanks for the patch: Acked-by: Harry van Haaren