From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C4C872A66 for ; Thu, 29 Mar 2018 13:02:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 04:02:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="28548061" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2018 04:02:56 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX107.ger.corp.intel.com ([169.254.10.157]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 12:02:55 +0100 From: "Van Haaren, Harry" To: "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "Ma, Liang J" CC: "Eads, Gage" , "Richardson, Bruce" , "santosh.shukla@caviumnetworks.com" , "nipun.gupta@nxp.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback Thread-Index: AQHTxaSOFIMHoYPoSU+386hg+n4cLaPnDBMA Date: Thu, 29 Mar 2018 11:02:55 +0000 Message-ID: References: <1521087130-20244-1-git-send-email-gage.eads@intel.com> <1521555187-25710-1-git-send-email-gage.eads@intel.com> <9184057F7FC11744A2107296B6B8EB1E3FA88B42@FMSMSX108.amr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjc5NzI4MjQtYjgzOC00OGJhLTgxYzItMDA0NWZmYjM5MDYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJRdTdlclkzVEQ0ZjVmekEyTEc4cnkzMXZ2Zm1XYVVVR2dZbGNWUTk4Z1FWM1NRSGpKWUwyMm5pc3p0NWlaYjQ2In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 11:02:59 -0000 (+Liang Ma for OPDL maintainer) Ping to maintainers, is the below suggestion acceptable for your PMDs? Summary of suggestion: - After event_dev_stop() dequeue() is no longer allowed on any thread - All events in the system (queues, ports, intermediary buffers) will be pa= ssed to a user-supplied callback for cleaning up events. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Van Haaren, Harry > Sent: Tuesday, March 27, 2018 9:20 AM > To: Eads, Gage ; jerin.jacob@caviumnetworks.com; > hemant.agrawal@nxp.com > Cc: Richardson, Bruce ; > santosh.shukla@caviumnetworks.com; nipun.gupta@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush > callback >=20 > > From: Eads, Gage > > Sent: Monday, March 26, 2018 10:59 PM > > To: Van Haaren, Harry ; dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Richardson, > Bruce > > ; santosh.shukla@caviumnetworks.com; > > nipun.gupta@nxp.com > > Subject: RE: [PATCH v4 1/2] eventdev: add device stop flush callback > > > > > > > > > -----Original Message----- > > > From: Van Haaren, Harry > > > Sent: Friday, March 23, 2018 11:57 AM > > > To: Eads, Gage ; dev@dpdk.org > > > Cc: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Richardso= n, > > > Bruce ; santosh.shukla@caviumnetworks.com= ; > > > nipun.gupta@nxp.com > > > Subject: RE: [PATCH v4 1/2] eventdev: add device stop flush callback > > > > > > > From: Eads, Gage > > > > Sent: Tuesday, March 20, 2018 2:13 PM > > > > To: dev@dpdk.org > > > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > > > ; hemant.agrawal@nxp.com; Richardson, > > > > Bruce ; santosh.shukla@caviumnetworks.c= om; > > > > nipun.gupta@nxp.com > > > > Subject: [PATCH v4 1/2] eventdev: add device stop flush callback > > > > > > > > When an event device is stopped, it drains all event queues. These > > > > events may contain pointers, so to prevent memory leaks eventdev no= w > > > > supports a user-provided flush callback that is called during the > queue > > drain > > > process. > > > > This callback is stored in process memory, so the callback must be > > > > registered by any process that may call rte_event_dev_stop(). > > > > > > > > This commit also clarifies the behavior of rte_event_dev_stop(). > > > > > > > > This follows this mailing list discussion: > > > > http://dpdk.org/ml/archives/dev/2018-January/087484.html > > > > > > > > Signed-off-by: Gage Eads > > > > > > > > > > > > > /** > > > > - * Stop an event device. The device can be restarted with a call t= o > > > > - * rte_event_dev_start() > > > > + * Stop an event device. > > > > + * > > > > + * This function causes all queued events to be drained. While > > > > + draining > > > > events > > > > + * out of the device, this function calls the user-provided flush > > > > + callback > > > > + * (if one was registered) once per event. > > > > + * > > > > + * This function does not drain events from event ports; the > > > > + application is > > > > + * responsible for flushing events from all ports before stopping = the > > > > device. > > > > > > > > > Question about how an application is expected to correctly cleanup al= l > the > > > events here. Note in particular the last part: "application is > responsible > > for > > > flushing events from all ports **BEFORE** stopping the device". > > > > > > Given the event device is still running, how can the application be s= ure > it > > has > > > flushed all the events (from the dequeue side in particular)? > > > > > > > Appreciate the feedback -- good points all around. > > > > I was expecting that the application would unlink queues from the ports= , > and > > then dequeue until each port has no events. However, there are PMDs for > which > > runtime port link/unlink is not supported, so I see that this is not a > viable > > approach. Plus, this adds the application burden that you describe belo= w. >=20 > +1. >=20 > > > > > > In order to drain all events from the ports, I was expecting the > following: > > > > > > // stop scheduling new events to worker cores > > > rte_event_dev_stop() > > > ---> callback gets called for each event > > > > > > // to dequeue events from each port, and app cleans them up? > > > FOR_EACH_PORT( rte_event_dev_dequeue(..., port_id, ...) ) > > > > > > > > > I'd like to avoid the dequeue-each-port() approach in application, as= it > > adds extra > > > burden to clean up correctly... > > > > Agreed, but for a different reason: that approach means we'd have to > change > > the documented eventdev behavior. rte_eventdev.h states that the > "schedule, > > enqueue and dequeue functions should not be invoked when the device is > > stopped," and this patch reiterates that in the rte_event_dev_stop() > > documentation ("Threads that continue to enqueue/dequeue while the devi= ce > is > > stopped, or being stopped, will result in undefined behavior"). Since a > PMD's > > stop cleanup code could just be repeated calls to a PMD's dequeue code, > > allowing applications to dequeue simultaneously could be troublesome. >=20 > All +1 too, good point about the header stating it is undefined behavior. >=20 >=20 > > > What if we say that dequeue() returns zero after stop() (leaving even= ts > > possibly > > > in the port-dequeue side SW buffers), and these events which were abo= ut > to > > be > > > dequeued by the worker core are also passed to the dev_stop_flush > callback? > > > > I'd prefer to have dequeue-while-stopped be unsupported, so we don't ne= ed > an > > additional check or synchronization in the datapath, but passing the > events in > > a port to the callback should work (for the sw PMD, at least). How does > that > > sound? >=20 >=20 > That's fine with me, both from design point of view, and SW PMD. >=20 > @HW PMD maintainers, would the above approach work for you? >=20 >=20 >=20