From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C218F1B743 for ; Wed, 4 Apr 2018 14:26:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 05:26:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,406,1517904000"; d="scan'208";a="217459820" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga006.fm.intel.com with ESMTP; 04 Apr 2018 05:26:50 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX107.ger.corp.intel.com ([169.254.10.157]) with mapi id 14.03.0319.002; Wed, 4 Apr 2018 13:26:50 +0100 From: "Van Haaren, Harry" To: "Varghese, Vipin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf Thread-Index: AQHTsWSwbPXbPMNB5EmHM4tqjHET5KPvMTpAgAFx14CAABgKsA== Date: Wed, 4 Apr 2018 12:26:49 +0000 Message-ID: References: <1519932900-10571-1-git-send-email-vipin.varghese@intel.com> <1519932900-10571-2-git-send-email-vipin.varghese@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1C5205@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1C5205@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWJjM2NhM2YtMTU3ZS00ZTRmLWI5NGYtMGM0ODIxNTNjYjUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJxbFQwUDdpMWpqVXFWQjgyaUxkZ3hyMW1md3B0bDNZaUg1NFVuYmcyMTZQWUZ3a0d1bk53ZDVqQ2VZZ3ZmM3A5In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 12:26:53 -0000 > -----Original Message----- > From: Varghese, Vipin > Sent: Wednesday, April 4, 2018 12:52 PM > To: Van Haaren, Harry ; dev@dpdk.org > Subject: RE: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf >=20 > Sure Harry, I am ok with your suggestion. Great! Next steps; 1) Would you respin v3 the 1/2 patch to fix the compiler error? -- You may include my Acked-by: in the fixed commit. 2) Send v3 patch from above as reply to the 1/2 patch (http://dpdk.org/dev/= patchwork/patch/35564/) -- Put Jerin on CC, as the patch should be ready for merge 3) Mark 1/2 and 2/2 (current revisions) as superseded to ensure 2/2 doesn't= get merged :) Cheers, -Harry > > -----Original Message----- > > From: Van Haaren, Harry > > Sent: Tuesday, April 3, 2018 6:20 PM > > To: Varghese, Vipin ; dev@dpdk.org > > Subject: RE: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf > > > > > -----Original Message----- > > > From: Varghese, Vipin > > > Sent: Thursday, March 1, 2018 7:35 PM > > > To: dev@dpdk.org; Van Haaren, Harry > > > Cc: Varghese, Vipin > > > Subject: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf > > I see the goal here - to ensure that the port buffer has items when we = next > enter > > this function, possibly reducing a stall waiting for the ring access. > > > > In theory this is a good idea - in practice, I see a small performance > degradation. > > Hence, I suggest we drop this patch from the patchset, and merge 1/2 al= one.