From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A2A7B1B211 for ; Wed, 9 May 2018 17:59:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 08:59:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,382,1520924400"; d="scan'208";a="39933244" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga008.jf.intel.com with ESMTP; 09 May 2018 08:59:40 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.249]) by IRSMSX101.ger.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0319.002; Wed, 9 May 2018 16:59:39 +0100 From: "Van Haaren, Harry" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v2 0/4] Clean up EAL runtime data paths Thread-Index: AQHT4HwgiVgyxiV/EUWKlPiP5K6pqaQnm9jQ Date: Wed, 9 May 2018 15:59:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzkzOGMzMDAtYWM5Ni00YTk4LTg5YzEtNmJmYzUwZDg1MzBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJzbmp2UlJDU1UwbHpCTGVUMGd4bk1EVDdKd3F2SXM2TEhrZktNaWl5NkJIODZRcENRSmg0NWF6M093VnRYY1wvTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/4] Clean up EAL runtime data paths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:59:43 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Monday, April 30, 2018 1:09 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; thomas@monjalon.net > Subject: [dpdk-dev] [PATCH v2 0/4] Clean up EAL runtime data paths >=20 > As has been suggested [1], all DPDK runtime paths should be put > into a single place. This patchset accomplishes exactly that. >=20 > If running as root, all files will be put under /var/run/dpdk/, > otherwise they will be put under $XDG_RUNTIME_PATH/dpdk/, or, if > that environment variable is not defined, all files will go under > /tmp/dpdk/. >=20 > [1] http://dpdk.org/dev/patchwork/patch/38688/ >=20 > v2: > - Rebase on rc1 >=20 > Anatoly Burakov (4): > eal: remove unused define > eal: rename function returning hugepage data path > eal: add directory for DPDK runtime data > eal: move all runtime data into DPDK runtime dir No full code review, high level comments: We have to be careful in changing /var/run/.rte_config, which has always be= en the default DPDK primary application lockfile. This has been used to identi= fy if a primary DPDK application is alive (see rte_eal_primary_proc_alive()) a= nd possibly the write-lock on this file is checked by other tools/utilities di= rectly without any DPDK function call. Changing the filepath just before a release isn't a good idea - we should t= reat this as an ABI/API break, as the change will break functionality in other p= rojects such as CollectD[1], which (by default ;) rely on the defaults. There is a = config file for CollectD to manually override the location, but this will cause he= adaches from a usability POV. I'm not opposed to the change - particularly as I gather the new memory sub= system causes a number of lockfiles to be created - but we must do our due diligen= ce and give other projects fair-warning that this change is coming. As such, I recommend this patchset in its current form (particularly patche= s 2,3,4) to be deferred past 18.05. -Harry [1] https://github.com/collectd/collectd/blob/master/src/utils_dpdk.c#L46