Re: [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

> From: Eads, Gage
> Sent: Thursday, May 31, 2018 2:56 PM
> To: dev@dpdk.org
> Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Rao, Nikhil <nikhil.rao@intel.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH 2/2] event/sw: support device stop flush callback
> 
> This commit also adds a flush callback test to the sw eventdev's selftest
> suite.
> 
> Signed-off-by: Gage Eads <gage.eads@intel.com>


One compile warning below, with that fixed;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


<snip>

> +static void
> +sw_drain_queues(struct rte_eventdev *dev)
> +{
> +	struct sw_evdev *sw = sw_pmd_priv(dev);
> +	int i, j;
> +
> +	for (i = 0; i < sw->qid_count; i++) {

I'm seeing an int vs unsigned comparison between i and sw->qid_count.

> +		for (j = 0; j < SW_IQS_MAX; j++)
> +			sw_drain_queue(dev, &sw->qids[i].iq[j]);
> +	}
> +}

<snip>