From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 66E8E1BF3C for ; Tue, 3 Jul 2018 18:12:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:12:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="63830782" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2018 09:11:59 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Jul 2018 17:11:55 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.146]) by irsmsx111.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0319.002; Tue, 3 Jul 2018 17:11:55 +0100 From: "Van Haaren, Harry" To: "Yigit, Ferruh" , Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , David Marchand , Olivier Matz , "Horton, Remy" Thread-Topic: [dpdk-dev] [PATCH] ethdev: document xstats API assumption Thread-Index: AQHUDuJav4RBT4MmG0yeJf49z7frW6R9ss2A Date: Tue, 3 Jul 2018 16:11:54 +0000 Message-ID: References: <1528359323-22885-1-git-send-email-david.marchand@6wind.com> <20180628141602.91695-1-ferruh.yigit@intel.com> In-Reply-To: <20180628141602.91695-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjZlYjZkZDItMzg4Zi00OTcxLWI3OTQtZmViOTE0NTY4NWY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieGxURkpMbXg4d2JqSjA2Qk5IdUJzNlJBSWp0QUJkMkprTEpOSGxISnVYZjNDNzYzU3FNR1ZhbkpWK1d0eGpUXC8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: document xstats API assumption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 16:12:02 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, June 28, 2018 3:16 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh ; David Marchand > ; Olivier Matz ; Horton= , > Remy > Subject: [dpdk-dev] [PATCH] ethdev: document xstats API assumption >=20 > Documents the assumption that 'xstats[i].id =3D=3D i' and > key=3Dxstats_names[i].name, value=3Dxstats[i].value >=20 > xstats[i].id is still used for xstats _by_id() APIs. >=20 > This patch reverts some part of the commit 6d52d1d4afb4 ("ethdev: > clarify extended statistics documentation") >=20 > Signed-off-by: Ferruh Yigit I'm also in favor of simplifying xstats APIs if possible, given we have a n= umber of PMDs using it, and they all adhere to this simplification; Acked-by: Harry van Haaren