From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 07EE42B92 for ; Tue, 28 Aug 2018 19:12:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 10:12:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,300,1531810800"; d="scan'208";a="65844097" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga007.fm.intel.com with ESMTP; 28 Aug 2018 10:12:38 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Aug 2018 18:12:37 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx155.ger.corp.intel.com ([169.254.14.243]) with mapi id 14.03.0319.002; Tue, 28 Aug 2018 18:12:37 +0100 From: "Van Haaren, Harry" To: Stephen Hemminger , "Power, Ciara" CC: "Archbold, Brian" , "Kenny, Emma" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure Thread-Index: AQHUOtoEXDtlvjLRJkGIcpB5svJvXaTN6dEAgAeEZrA= Date: Tue, 28 Aug 2018 17:12:36 +0000 Message-ID: References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-2-git-send-email-ciara.power@intel.com> <20180823162222.49445f97@xeon-e3> In-Reply-To: <20180823162222.49445f97@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2ZlZjY2YTQtYmJlOS00ZDhlLWFmN2EtNzJhNzQ3YzI2ZDQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZTdqRlwvZFF2V0I4NzA1bFwvMFwva0RyZEo3U2d1SlhHOENITGI0V0lTK3FOZ01VeVBDQ211VWZHd1d0OXpnYWJOYSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 17:12:50 -0000 > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, August 24, 2018 12:22 AM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.= org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastructure >=20 > On Thu, 23 Aug 2018 13:08:03 +0100 > Ciara Power wrote: >=20 > > +/* Logging Macros */ > > +extern int telemetry_log_level; > > + > > +#define TELEMETRY_LOG(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ##level, telemetry_log_level, "%s(): "fmt "\n", \ > > + __func__, ##args) > > + > > +#define TELEMETRY_LOG_ERR(fmt, args...) \ > > + TELEMETRY_LOG(ERR, fmt, ## args) > > + > > +#define TELEMETRY_LOG_WARN(fmt, args...) \ > > + TELEMETRY_LOG(WARNING, fmt, ## args) > > + > > +#define TELEMETRY_LOG_INFO(fmt, args...) \ > > + TELEMETRY_LOG(INFO, fmt, ## args) > > + > > +typedef struct telemetry_impl { > > + pthread_t thread_id; > > + int thread_status; > > + uint32_t socket_id; > > +} telemetry_impl; > > + >=20 > Your logging macros follow the standard DPDK style. Including automatical= ly > adding a new line. But as I look at the code, many of the TELEMETRY_LOG > calls > have a newline in the format. Therefore your log messages will be double > spaced. Correct, will get that fixed. Thanks for reviewing! Looking forward to Userspace, curious to hear of your use-cases for Telemetry lib, assuming you have some in mind.