From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A7BEA00E6 for ; Thu, 8 Aug 2019 17:32:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E4271BE7B; Thu, 8 Aug 2019 17:32:11 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2F4A31BE6C; Thu, 8 Aug 2019 17:32:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 08:32:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="350209235" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 08 Aug 2019 08:32:06 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by IRSMSX101.ger.corp.intel.com ([169.254.1.88]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 16:32:05 +0100 From: "Van Haaren, Harry" To: "Sirvys, Andrius" , "Laatz, Kevin" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Ferriter, Cian" , "Lipiec, Herakliusz" Thread-Topic: [PATCH v3] usertools: fix input handling in telemetry script Thread-Index: AQHVTfbtShNQWSCgsk2h/F1iAbNv2abxYAlg Date: Thu, 8 Aug 2019 15:32:04 +0000 Message-ID: References: <20190807130458.16754-1-andrius.sirvys@intel.com> <20190808143753.16788-1-andrius.sirvys@intel.com> In-Reply-To: <20190808143753.16788-1-andrius.sirvys@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTMzMDdjNzctYTU5Zi00ZDg1LTg3MjEtNGQ3MTU3M2ZlNTcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRjhrRDlKdzZma0pvVERBbU5hb0FqdmdsTGtvU1JZNnpqRkdoa3pYK1gwVWQ4WVpzeVN5OUViMnZsWkp5aWE2USJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sirvys, Andrius > Sent: Thursday, August 8, 2019 3:38 PM > To: Laatz, Kevin > Cc: dev@dpdk.org; stable@dpdk.org; Van Haaren, Harry > ; Ferriter, Cian ; > Lipiec, Herakliusz ; Sirvys, Andrius > > Subject: [PATCH v3] usertools: fix input handling in telemetry script >=20 > This commit removes the unnecesarry ast.literal_eval() function call > from the input handling, which now relies just on raw_input() to get > its input. >=20 > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Cc: andrius.sirvys@intel.com >=20 > Signed-off-by: Andrius Sirvys > --- > v2: Removed unnecessary comments > v3: Reduced scope of changes only to required Python 2 fix >=20 > Please note that the dpdk-telemetry-client.py script has a number of > issues with Python3 support. Fixing Python3 support is being deferred > to DPDK 19.11 release. Thanks for the patch re-spin Andrius. This is the smallest change possible to fix the current issue, and I recommend including in 19.08 release. Agree the Python3 support requires larger refactoring, which should be undertaken for 19.11. Acked-by: Harry van Haaren