* [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete
@ 2018-11-08 21:29 Dekel Peled
2018-11-08 22:12 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Dekel Peled @ 2018-11-08 21:29 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, orika
Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
This function is used by flow_fdir_filter_add() to check if same rule
exists, and by flow_fdir_filter_delete() to find flow rule to delete.
The function compared actions conf pointers, changed to compare
actions type only.
Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
Cc: yskoh@mellanox.com
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8039664..21d65f4 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2663,7 +2663,7 @@ struct rte_flow *
FLOW_FDIR_CMP(f1, f2, l3_mask) ||
FLOW_FDIR_CMP(f1, f2, l4) ||
FLOW_FDIR_CMP(f1, f2, l4_mask) ||
- FLOW_FDIR_CMP(f1, f2, actions[0]))
+ FLOW_FDIR_CMP(f1, f2, actions[0].type))
return 1;
if (f1->actions[0].type == RTE_FLOW_ACTION_TYPE_QUEUE &&
FLOW_FDIR_CMP(f1, f2, queue))
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete
2018-11-08 21:29 [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete Dekel Peled
@ 2018-11-08 22:12 ` Yongseok Koh
2018-11-11 12:41 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-11-08 22:12 UTC (permalink / raw)
To: Dekel Peled; +Cc: Shahaf Shuler, dev, Ori Kam
> On Nov 8, 2018, at 1:29 PM, Dekel Peled <dekelp@mellanox.com> wrote:
>
> Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
> This function is used by flow_fdir_filter_add() to check if same rule
> exists, and by flow_fdir_filter_delete() to find flow rule to delete.
>
> The function compared actions conf pointers, changed to compare
> actions type only.
>
> Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
> Cc: yskoh@mellanox.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete
2018-11-08 22:12 ` Yongseok Koh
@ 2018-11-11 12:41 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-11-11 12:41 UTC (permalink / raw)
To: Yongseok Koh, Dekel Peled; +Cc: dev, Ori Kam
Friday, November 9, 2018 12:12 AM¸ Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix flow director add and delete
>
>
> > On Nov 8, 2018, at 1:29 PM, Dekel Peled <dekelp@mellanox.com> wrote:
> >
> > Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
> > This function is used by flow_fdir_filter_add() to check if same rule
> > exists, and by flow_fdir_filter_delete() to find flow rule to delete.
> >
> > The function compared actions conf pointers, changed to compare
> > actions type only.
> >
> > Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
> > Cc: yskoh@mellanox.com
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-11 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 21:29 [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete Dekel Peled
2018-11-08 22:12 ` Yongseok Koh
2018-11-11 12:41 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).