From: "Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)" <xuanziyang2@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wangxiaoyun (Cloud,
Network Chip Application Development Dept)"
<cloud.wangxiaoyun@huawei.com>,
Shahar Belkar <shahar.belkar@huawei.com>,
Tanya Brokhman <tanya.brokhman@huawei.com>,
Luoxianjun <luoxianjun@huawei.com>
Subject: [dpdk-dev] 答复: [PATCH v5 14/15] net/hinic: add tx/rx package burst
Date: Wed, 26 Jun 2019 15:58:15 +0000 [thread overview]
Message-ID: <EA3B33EA29B44042A5337C4DC59AF4505EEF7699@dggeml512-mbx.china.huawei.com> (raw)
In-Reply-To: <120e674c-091d-d817-26b6-e0e9d28073e1@intel.com>
> On 6/19/2019 5:20 PM, Ziyang Xuan wrote:
> > This patch add package sending and receiving function codes.
> >
> > Signed-off-by: Ziyang Xuan <xuanziyang2@huawei.com>
>
> <...>
>
> > @@ -543,6 +728,113 @@ void hinic_free_all_rx_skbs(struct hinic_rxq *rxq)
> > }
> > }
> >
> > +static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32,
> > + volatile void *src_be32)
> > +{
> > +#ifndef __ARM64_NEON__
> > + volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
> > + __m128i *wqe_le = (__m128i *)dst_le32;
> > + __m128i shuf_mask = _mm_set_epi8(12, 13, 14, 15, 8, 9, 10,
> > + 11, 4, 5, 6, 7, 0, 1, 2, 3);
> > +
> > + /* l2nic just use first 128 bits */
> > + wqe_le[0] = _mm_shuffle_epi8(wqe_be[0], shuf_mask); #else
> > + volatile uint8x16_t *wqe_be = (volatile uint8x16_t *)src_be32;
> > + uint8x16_t *wqe_le = (uint8x16_t *)dst_le32;
> > + const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10,
> > + 9, 8, 15, 14, 13, 12};
> > +
> > + /* l2nic just use first 128 bits */
> > + wqe_le[0] = vqtbl1q_u8(wqe_be[0], shuf_mask); #endif }
>
> I am aware documentation says only arm64 and x86_64 are supported and
> default config files default values implemented that way, still I believe it is
> safer to not just assume it is either one or other.
> What do you think explicitly check X86_64 too, as done for ARM64?
Hi Ferruh,
As you said, we just support arm64 and x86_64. First we determine arm64 using
"CONFIG_RTE_ARCH_ARM64" to define "__ARM64_NEON__" micro in Makefile.
If it has not defined "__ARM64_NEON__", it must be X86_64. This is our present situation.
I think we can use the same method to determine "X86_64" using "CONFIG_RTE_ARCH_X86_64".
If it is neither "ARM64" nor "X86_64", we can use "rte_be_to_cpu_32" and "rte_cpu_to_be_32".
How do you think about this?
Looking forward to your comments.
Thank you!
Best Regards,
Ziyang Xuan
next prev parent reply other threads:[~2019-06-26 15:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 15:45 [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic Ziyang Xuan
2019-06-19 15:46 ` [dpdk-dev] [PATCH v5 01/15] net/hinic/base: add HW registers definition Ziyang Xuan
2019-06-19 15:50 ` [dpdk-dev] [PATCH v5 02/15] net/hinic/base: add HW interfaces of bar operation Ziyang Xuan
2019-06-19 15:47 ` Ziyang Xuan
2019-06-19 15:54 ` [dpdk-dev] [PATCH v5 03/15] net/hinic/base: add api command channel code Ziyang Xuan
2019-06-19 15:55 ` [dpdk-dev] [PATCH v5 04/15] net/hinic/base: add support for cmdq mechanism Ziyang Xuan
2019-06-19 15:56 ` [dpdk-dev] [PATCH v5 05/15] net/hinic/base: add eq mechanism function code Ziyang Xuan
2019-06-19 15:57 ` [dpdk-dev] [PATCH v5 06/15] net/hinic/base: add mgmt module " Ziyang Xuan
2019-06-19 16:02 ` [dpdk-dev] [PATCH v5 07/15] net/hinic/base: add code about hardware operation Ziyang Xuan
2019-06-19 15:58 ` Ziyang Xuan
2019-06-19 16:04 ` [dpdk-dev] [PATCH v5 08/15] net/hinic/base: add nic business configurations Ziyang Xuan
2019-06-19 16:05 ` [dpdk-dev] [PATCH v5 09/15] net/hinic/base: add context and work queue support Ziyang Xuan
2019-06-19 16:08 ` [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers Ziyang Xuan
2019-06-26 11:54 ` Ferruh Yigit
2019-06-19 16:09 ` [dpdk-dev] [PATCH v5 11/15] net/hinic: add hinic PMD build and doc files Ziyang Xuan
2019-06-19 16:13 ` Ziyang Xuan
2019-06-26 11:55 ` Ferruh Yigit
2019-06-19 16:16 ` [dpdk-dev] [PATCH v5 12/15] net/hinic: add device initailization Ziyang Xuan
2019-06-19 16:14 ` Ziyang Xuan
2019-06-19 16:30 ` Ziyang Xuan
2019-06-19 16:18 ` [dpdk-dev] [PATCH v5 13/15] net/hinic: add start stop close queue ops Ziyang Xuan
2019-06-19 16:32 ` Ziyang Xuan
2019-06-19 16:20 ` [dpdk-dev] [PATCH v5 14/15] net/hinic: add tx/rx package burst Ziyang Xuan
2019-06-19 16:25 ` Ziyang Xuan
2019-06-26 11:54 ` Ferruh Yigit
2019-06-26 15:58 ` Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions) [this message]
2019-06-26 16:05 ` [dpdk-dev] 答复: " Ferruh Yigit
2019-06-19 16:23 ` [dpdk-dev] [PATCH v5 15/15] net/hinic: add rss stats promisc ops Ziyang Xuan
2019-06-26 11:56 ` [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EA3B33EA29B44042A5337C4DC59AF4505EEF7699@dggeml512-mbx.china.huawei.com \
--to=xuanziyang2@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=luoxianjun@huawei.com \
--cc=shahar.belkar@huawei.com \
--cc=tanya.brokhman@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).