DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
To: "Sirvys, Andrius" <andrius.sirvys@intel.com>,
	"Laatz, Kevin" <kevin.laatz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Sirvys, Andrius" <andrius.sirvys@intel.com>
Subject: Re: [dpdk-dev] [PATCH] usertools: dpdk-telemetry-client.py run into	looping status
Date: Wed, 7 Aug 2019 11:16:35 +0000	[thread overview]
Message-ID: <EB47986807B11C41AD0C5C13A40DE883612B88@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20190807110202.15712-1-andrius.sirvys@intel.com>

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrius Sirvys
> 
> The ast.literal_eval() was used incorrectly and wouldn't properly retrieve the
> user option. Was causing the options to keep being listed in a loop. Removed
> and replaced with raw_input() being cast to an int.
> Works as expected now.
> 
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Cc: andrius.sirvys@intel.com
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> ---
>  usertools/dpdk-telemetry-client.py | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-
> client.py
> index 4b0502ff9..3b53b6949 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -16,9 +16,9 @@
>  DEFAULT_FP = "/var/run/dpdk/default_client"
> 
>  try:
> -	raw_input  # Python 2
> +        raw_input  # Python 2
>  except NameError:
> -	raw_input = input  # Python 3
> +        raw_input = input  # Python 3
> 
>  class Socket:
> 
> @@ -78,7 +78,8 @@ def requestMetrics(self): # Requests metrics for given
> client
> 
>      def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests
> metrics for given client
>          print("\nPlease enter the number of times you'd like to continuously
> request Metrics:")
> -        n_requests = int(ast.literal_eval(raw_input("\n:")))
> +        #n_requests = int(ast.literal_eval(raw_input("\n:")))

If youre changing a line, you probably want to remove the old one, not comment it out.

> +        n_requests = int(raw_input("\n:"))
>          print("\033[F") #Removes the user input from screen, cleans it up
>          print("\033[K")
>          for i in range(n_requests):
> @@ -99,7 +100,8 @@ def interactiveMenu(self, sleep_time): # Creates
> Interactive menu within the scr
>              print("[4] Unregister client")
> 
>              try:
> -                self.choice = int(ast.literal_eval(raw_input("\n:")))
> +                #self.choice = int(ast.literal_eval(raw_input("\n:")))

Same as above.

> +                self.choice = int(raw_input("\n:"))
>                  print("\033[F") #Removes the user input for screen, cleans it up
>                  print("\033[K")
>                  if self.choice == 1:
> --
> 2.17.1

Regards,
Herakliusz 

      reply	other threads:[~2019-08-07 11:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 11:02 Andrius Sirvys
2019-08-07 11:16 ` Lipiec, Herakliusz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EB47986807B11C41AD0C5C13A40DE883612B88@IRSMSX104.ger.corp.intel.com \
    --to=herakliusz.lipiec@intel.com \
    --cc=andrius.sirvys@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).