From: Yongseok Koh <yskoh@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change
Date: Mon, 7 Aug 2017 22:19:56 +0000 [thread overview]
Message-ID: <EC601F5F-1DC5-41E4-98D9-6FBF739A6395@mellanox.com> (raw)
In-Reply-To: <20170706150751.27251-1-stephen@networkplumber.org>
> On Jul 6, 2017, at 8:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> VMBUS support will use GUID in eth_dev_data name field which requires
> at least 37 characters. Plan for increase in size now.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 2e708dbe0deb..d5b70c50064a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -95,3 +95,7 @@ Deprecation Notices
> The non-"do-sig" versions of the hash tables will be removed
> (including the ``signature_offset`` parameter)
> and the "do-sig" versions renamed accordingly.
> +
> +* ethdev: An ABI change is planned for 17.11 for the structure eth_dev_data.
Isn't it better to use "``rte_eth_dev_data``"?
> + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN from 32 to
> + 64 characters to allow using a globally unique identifier (GUID) in this field.
Except for the small comment above,
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks,
Yongseok
next parent reply other threads:[~2017-08-07 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170706150751.27251-1-stephen@networkplumber.org>
2017-08-07 22:19 ` Yongseok Koh [this message]
2017-08-08 4:56 ` Shahaf Shuler
2017-08-08 9:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC601F5F-1DC5-41E4-98D9-6FBF739A6395@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).