From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EA98B91B6 for ; Tue, 5 Jan 2016 03:21:16 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 04 Jan 2016 18:21:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,523,1444719600"; d="scan'208";a="628068899" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 04 Jan 2016 18:21:15 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 18:21:15 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 18:21:15 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.220]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.111]) with mapi id 14.03.0248.002; Tue, 5 Jan 2016 10:21:13 +0800 From: "Tan, Jianfeng" To: "Xie, Huawei" , "dev@dpdk.org" Thread-Topic: [PATCH] fix checkpatch errors Thread-Index: AQHRRxf+TlC//7ncjESat9NirGwPAp7sLrQQ Date: Tue, 5 Jan 2016 02:21:12 +0000 Message-ID: References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> In-Reply-To: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 02:21:17 -0000 > -----Original Message----- > From: Xie, Huawei > Sent: Monday, January 4, 2016 9:52 AM > To: dev@dpdk.org > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei > Subject: [PATCH] fix checkpatch errors >=20 > Signed-off-by: Huawei Xie ... > mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name)); > - return (rte_mempool_lookup((const char *)pool_name)); > + return rte_mempool_lookup((const char *)pool_name); Hi Huawei, Assume this patch is to solve below error (reported by checkpatch): ERROR: return is not a function, parentheses are not required So maybe above fix is not necessary? Involve more people to discuss. And please include the error message in the commit message. Thanks, Jianfeng