From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 65704374F
 for <dev@dpdk.org>; Wed,  1 Jun 2016 09:44:36 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga103.jf.intel.com with ESMTP; 01 Jun 2016 00:44:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,400,1459839600"; d="scan'208";a="712083519"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2016 00:44:35 -0700
Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 1 Jun 2016 00:44:35 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 1 Jun 2016 00:44:34 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.220]) with mapi id 14.03.0248.002;
 Wed, 1 Jun 2016 15:44:33 +0800
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>,
 "rich.lane@bigswitch.com" <rich.lane@bigswitch.com>, "mst@redhat.com"
 <mst@redhat.com>, "nakajima.yoshihiro@lab.ntt.co.jp"
 <nakajima.yoshihiro@lab.ntt.co.jp>, "p.fedin@samsung.com"
 <p.fedin@samsung.com>, "ann.zhuangyanying@huawei.com"
 <ann.zhuangyanying@huawei.com>, "mukawa@igel.co.jp" <mukawa@igel.co.jp>,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
Thread-Topic: [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup
Thread-Index: AQHRumHcBDeUGj/vd0yx7xyzPWMfz5/TtjsAgACGJcA=
Date: Wed, 1 Jun 2016 07:44:33 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E36105F8B99@SHSMSX103.ccr.corp.intel.com>
References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com>
 <1464605739-140761-1-git-send-email-jianfeng.tan@intel.com>
 <1464605739-140761-3-git-send-email-jianfeng.tan@intel.com>
 <20160601073814.GD10038@yliu-dev.sh.intel.com>
In-Reply-To: <20160601073814.GD10038@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 2/8] virtio: clean up
	virtio_dev_queue_setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jun 2016 07:44:37 -0000

Hi Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Wednesday, June 1, 2016 3:38 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Xie, Huawei; rich.lane@bigswitch.com; mst@redhat.com;
> nakajima.yoshihiro@lab.ntt.co.jp; p.fedin@samsung.com;
> ann.zhuangyanying@huawei.com; mukawa@igel.co.jp;
> nhorman@tuxdriver.com
> Subject: Re: [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup
>=20
> On Mon, May 30, 2016 at 10:55:33AM +0000, Jianfeng Tan wrote:
> > Abstract vring hdr desc init as an inline method.
>=20
> What's this patch for then? In your last version, it will be invoked
> twice, but it turned out to be wrong. So, why keeping this change?
> I didn't see it improves anything.
>=20

Yes, for now, only one version is kept because the position to call this fu=
nction is changed. And I think this segment of code functions as a special =
purpose, which can be abstracted as a function, make sense?

Thanks,
Jianfeng