From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5DED55A55 for ; Thu, 18 Aug 2016 12:19:26 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 18 Aug 2016 03:19:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="scan'208";a="867514018" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 18 Aug 2016 03:19:17 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Aug 2016 03:19:17 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Aug 2016 03:19:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Thu, 18 Aug 2016 18:19:15 +0800 From: "Tan, Jianfeng" To: Maxime Coquelin , "dev@dpdk.org" CC: "yuanhan.liu@linux.intel.com" Thread-Topic: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option Thread-Index: AQHR+RPXGUJ9ZKvghUWfE/QZF5/IwqBN0pOAgACup6A= Date: Thu, 18 Aug 2016 10:19:15 +0000 Message-ID: References: <1471499173-11749-1-git-send-email-jianfeng.tan@intel.com> <56458495-5ee1-ff9c-c2d0-819b120cfcbc@redhat.com> In-Reply-To: <56458495-5ee1-ff9c-c2d0-819b120cfcbc@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 10:19:26 -0000 Hi Maxime, > -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] > Sent: Thursday, August 18, 2016 3:52 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: yuanhan.liu@linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option >=20 >=20 >=20 > On 08/18/2016 07:46 AM, Jianfeng Tan wrote: > > When VMDQ is enabled, different NICs have different behaviors for > > disabling VLAN strip. In detail, i40e only enables/disables it of > > PF's main vsi; fm10k cannot disable VLAN strip, etc. We now remove > > this option, --vlan-strip, to reduce any confusion. And now, VLAN > > strip will be enabled and cannot be disabled. > > > > Reported-by: Qian Xu > > Signed-off-by: Jianfeng Tan > > --- > > doc/guides/sample_app_ug/vhost.rst | 11 ++++------- > > examples/vhost/main.c | 26 +------------------------- > > 2 files changed, 5 insertions(+), 32 deletions(-) >=20 > Minor comment below. Other than that: > Reviewed-by: Maxime Coquelin >=20 > > diff --git a/doc/guides/sample_app_ug/vhost.rst > b/doc/guides/sample_app_ug/vhost.rst > > index 2b7defc..a204f78 100644 > > --- a/doc/guides/sample_app_ug/vhost.rst > > +++ b/doc/guides/sample_app_ug/vhost.rst > > @@ -496,13 +496,10 @@ due to the large and complex code, it's better to > redesign it than fixing > > it to make it work again. Hence, zero copy may be added back later. > > > > **VLAN strip.** > > -The VLAN strip option enable/disable the VLAN strip on host, if disabl= ed, > the guest will receive the packets with VLAN tag. > > -It is enabled by default. > > - > > -.. code-block:: console > > - > > - ./vhost-switch -c f -n 4 --socket-mem 1024 --huge-dir /mnt/huge \ > > - -- --vlan-strip [0, 1] > > +VLAN strip option is removed, because different NICs have different > behaviors > > +when disabling VLAN strip. Such feature, which heavily depends on > hardware, > > +should be removed from this example to deduce confusion. Now, VLAN > strip is > I'm not a native English speaker, but I would use "reduce" instead of > "deduce" here. I might be wrong, so feel free to keep as-is if > appropriate. Nice catch! Yes, "reduce" instead of "deduce". Thanks, Jianfeng >=20 > Thanks, > Maxime