From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 810CB5589 for ; Tue, 13 Sep 2016 02:50:36 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 12 Sep 2016 17:50:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,325,1470726000"; d="scan'208";a="760035608" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 12 Sep 2016 17:50:19 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Sep 2016 17:50:19 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.102]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0248.002; Tue, 13 Sep 2016 08:50:17 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon , Yuanhan Liu CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure Thread-Index: AQHR7iYYHqPS1AL8k0WaEzkOwM7UoaBz6C0AgAHeYxD//4ktgIABgldA Date: Tue, 13 Sep 2016 00:50:16 +0000 Message-ID: References: <1470297529-100773-1-git-send-email-jianfeng.tan@intel.com> <20160911120906.GV23158@yliu-dev.sh.intel.com> <294735333.lTyYAqE8WY@xps13> In-Reply-To: <294735333.lTyYAqE8WY@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 00:50:37 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, September 12, 2016 5:36 PM > To: Tan, Jianfeng; Yuanhan Liu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on > VXLAN failure >=20 > 2016-09-12 08:42, Tan, Jianfeng: > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > FYI, my testrobot caught some errors when this patch is applied. > > > > It's because this patch set has dependency on a previous patch set, whi= ch > seems a difficult scenario to handle. There's no standard to state the > dependency, right? >=20 > No there is no standard to state the dependency. > We need one. Actually, there are 3 kinds of dependencies: > - a well know dependency when sending a patch > - implicit dependency on the HEAD > (can fail if a conflicting patch is pushed) > - dependency on a specific tree (next-*) >=20 > I suggest using: > Depends-on: pw | > Examples: > Depends-on: pw 33000 > Depends-on: master 3643b0f > Depends-on: next-net f33e00 >=20 > It won't work well when a patch depends on a pending patch series > because the cover letter has no patchwork identifier. > It will be solved with the next version of patchwork (in few months). > In the meantime, we can point to the first patch of the series. >=20 > Comments/ideas? I think it's a great idea which can make the work of auto tools much more e= asier and less false positive errors. Besides, it will improve the experien= ce of code review. Thanks, Jianfeng