From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 1456E558B
 for <dev@dpdk.org>; Thu, 13 Oct 2016 13:24:15 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga101.fm.intel.com with ESMTP; 13 Oct 2016 04:24:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="19243497"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga005.jf.intel.com with ESMTP; 13 Oct 2016 04:24:14 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 13 Oct 2016 04:24:14 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0248.002;
 Thu, 13 Oct 2016 19:24:11 +0800
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Pattan, Reshma" <reshma.pattan@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call
Thread-Index: AQHSIwOlRgtJ22f6j06PJThNAAOfm6CmQfMA
Date: Thu, 13 Oct 2016 11:24:10 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E364E6B47E6@SHSMSX103.ccr.corp.intel.com>
References: <1476110148-31624-1-git-send-email-reshma.pattan@intel.com>
In-Reply-To: <1476110148-31624-1-git-send-email-reshma.pattan@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir
 call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 11:24:16 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Monday, October 10, 2016 10:36 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir cal=
l
>=20
> From: Reshma Pattan <reshma.pattan@intel.com>
>=20
> Inside the function pdump_get_socket_path(), pdump socket
> directories are created using mkdir() call with permissions 700,
> which was assigning wrong permissions to the directories
> i.e. "d-w-r-xr-T" instead of drwx---. The reason is mkdir() call
> doesn't consider 700 as an octal value until unless 0 is explicitly
> added before the value. Because of this, socket creation failure is
> observed when DPDK application was ran in non root user mode.
> DPDK application running in root user mode never reported the issue.
>=20
> So 0 is prefixed to the value to create directories with
> the correct permissions.
>=20
> Fixes: e4ffa2d3 ("pdump: fix error handlings")
> Fixes: bdd8dcc6 ("pdump: fix default socket path")
>=20
> Reported-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>

Tested-by: Jianfeng Tan <jianfeng.tan@intel.com>

Thank you Reshma.