From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6261D2B86 for ; Mon, 26 Dec 2016 07:59:02 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 25 Dec 2016 22:59:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,404,1477983600"; d="scan'208";a="47211590" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 25 Dec 2016 22:59:01 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Dec 2016 22:59:01 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Dec 2016 22:59:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Mon, 26 Dec 2016 14:58:58 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Liang, Cunming" Thread-Topic: [PATCH v2 3/7] net/virtio_user: move vhost user specific code Thread-Index: AQHSXOwiggbFybDGtUewOQJmsJp5o6EZQoyAgACNz6A= Date: Mon, 26 Dec 2016 06:58:58 +0000 Message-ID: References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-4-git-send-email-jianfeng.tan@intel.com> <20161226062821.GB19288@yliu-dev.sh.intel.com> In-Reply-To: <20161226062821.GB19288@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/7] net/virtio_user: move vhost user specific code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2016 06:59:02 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, December 26, 2016 2:28 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Liang, Cunming > Subject: Re: [PATCH v2 3/7] net/virtio_user: move vhost user specific cod= e >=20 > On Fri, Dec 23, 2016 at 07:14:22AM +0000, Jianfeng Tan wrote: > > To support vhost kernel as the backend of net_virtio_user in coming > > patches, we move vhost_user specific structs and macros into > > vhost_user.c, and only keep common definitions in vhost.h. >=20 > Good. >=20 > > Besides, remove VHOST_USER_MQ feature check, it will be added back > > in following multiqueue patch. >=20 > Why then? Only vhost user recognizes this feature bit, and vhost kernel does not. My = intension is to put those vhost user specific code inside vhost user. And i= n fact, I forget to add it back. I should add it back in this patch. Thanks, Jianfeng >=20 > --yliu