From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 28E3914EC
 for <dev@dpdk.org>; Tue, 17 Jan 2017 06:24:04 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga101.fm.intel.com with ESMTP; 16 Jan 2017 21:24:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,242,1477983600"; d="scan'208";a="49557607"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga004.jf.intel.com with ESMTP; 16 Jan 2017 21:24:03 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 16 Jan 2017 21:24:02 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002;
 Tue, 17 Jan 2017 13:23:59 +0800
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "Yao, Lei A" <lei.a.yao@intel.com>
Thread-Topic: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype option
Thread-Index: AQHScAdgsNkJGMEEKE+Uy3vfGXl8P6E7m3aAgACIApA=
Date: Tue, 17 Jan 2017 05:23:58 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3651115FD7@SHSMSX103.ccr.corp.intel.com>
References: <1484578022-92705-1-git-send-email-jianfeng.tan@intel.com>
 <1484578022-92705-10-git-send-email-jianfeng.tan@intel.com>
 <20170117051611.GJ10293@yliu-dev.sh.intel.com>
In-Reply-To: <20170117051611.GJ10293@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 09/10] examples/l3fwd-power: add
	parse-ptype option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2017 05:24:05 -0000



> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Tuesday, January 17, 2017 1:16 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; stephen@networkplumber.org; Yao, Lei A
> Subject: Re: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype
> option
>=20
> On Mon, Jan 16, 2017 at 02:47:01PM +0000, Jianfeng Tan wrote:
> > +#if (APP_LOOKUP_METHOD =3D=3D APP_LOOKUP_LPM)
> > +	if (ptype_l3_ipv4)
> > +#else
> > +	// APP_LOOKUP_EXACT_MATCH
>=20
> No c++ comment.

OK.

>=20
> Besides, this patchset misses the release note. Also bear in mind I
> think this feature deserves a howto doc.

Sorry, I missed that in my stash. Will send a new version with fixing Steph=
en's comment.

Thanks,
Jianfeng

>=20
> 	--yliu