From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4B6DF3B5 for ; Fri, 10 Feb 2017 12:20:48 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2017 03:20:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,140,1484035200"; d="scan'208";a="63487860" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2017 03:20:46 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 10 Feb 2017 03:20:46 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 10 Feb 2017 03:20:46 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 10 Feb 2017 19:20:44 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Mcnamara, John" , "yuanhan.liu@linux.intel.com" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio Thread-Index: AQHSgu5+7GANzXMfh0aa9tGTsxnHKqFga14AgAEd4oCAAI+l8A== Date: Fri, 10 Feb 2017 11:20:43 +0000 Message-ID: References: <1485243248-27082-1-git-send-email-jianfeng.tan@intel.com> <1486656406-144541-4-git-send-email-jianfeng.tan@intel.com> <21c3f97a-c13b-2d5b-84cd-4d84a2d23717@intel.com> <7792524.kWq49NKEN6@xps13> In-Reply-To: <7792524.kWq49NKEN6@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 11:20:48 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, February 10, 2017 6:44 PM > To: Tan, Jianfeng > Cc: Yigit, Ferruh; dev@dpdk.org; Mcnamara, John; > yuanhan.liu@linux.intel.com; stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_u= io >=20 > 2017-02-09 17:40, Ferruh Yigit: > > On 2/9/2017 4:06 PM, Jianfeng Tan wrote: > > > This ABI changes to remove iomem and ioport mapping in igb_uio. The > > > purpose of this changes was to fix a bug: when DPDK app crashes, > > > those devices by igb_uio are not stopped either DPDK PMD driver or > > > igb_uio driver. > > > > > > Then it has been pointed out by Stephen Hemminger that it has > > > backward compatibility issue: cannot run old version DPDK on > > > modified igb_uio. > > > > > > However, we still have not figure out a new way to fix this bug > > > without this change. Let's postpone this deprecation announcement > > > in case this change cannot be avoided. > > > > > > Fixes: 3bac1dbc1ed ("doc: announce iomem and ioport removal from > igb_uio") > > > > > > Suggested-by: Stephen Hemminger > > > Suggested-by: Ferruh Yigit > > > Suggested-by: Thomas Monjalon > > > Signed-off-by: Jianfeng Tan > > > > Acked-by: Ferruh Yigit >=20 > Applied, thanks >=20 > The images are not real vector images and are almost unreadable. > Please make the effort to use inkscape in order to have images > we can update. Apologies for that. I've submitted a patch to changes the images. And thank= you for the solution. >=20 > I did some changes: s/virtio_user/virtio-user/ in order to be consistent. > Like for vhost-user, we use the underscore only in code. Thank you for that. Regards, Jianfeng