From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CA827316B for ; Fri, 14 Apr 2017 06:36:08 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 13 Apr 2017 21:36:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="956011224" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 13 Apr 2017 21:36:07 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 13 Apr 2017 21:36:06 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 13 Apr 2017 21:36:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Fri, 14 Apr 2017 12:35:58 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" Thread-Topic: [PATCH v2] net/virtio-user: fix cannot get initialized Thread-Index: AQHStD4/Rg593vZ12UC4OITHTWR256HDv2OAgACIsaA= Date: Fri, 14 Apr 2017 04:35:57 +0000 Message-ID: References: <1491551860-15005-1-git-send-email-jianfeng.tan@intel.com> <1492078287-138040-1-git-send-email-jianfeng.tan@intel.com> <20170414042423.GI7333@yliu-dev.sh.intel.com> In-Reply-To: <20170414042423.GI7333@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix cannot get initialized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 04:36:09 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Friday, April 14, 2017 12:24 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coquelin@redhat.com > Subject: Re: [PATCH v2] net/virtio-user: fix cannot get initialized >=20 > On Thu, Apr 13, 2017 at 10:11:27AM +0000, Jianfeng Tan wrote: > > The feature negotiation in virtio-user is proven to be broken, > > which results in device initialization failure. > > > > Originally, we get features from vhost backend, and remove those > > that are not supported. But when new feature is added, for example, > > VIRTIO_NET_F_MTU, we fail to remove this new feature. Then, this > > new feature will be negotiated, as both frontend and backend claim > > to support this feature. > > > > To fix it, we add a macro to record supported featues, as a filter > > to remove newly added features. >=20 > Yes, this is much better! You now don't have to worry that virtio-user > will be broken every time we add a new feature. >=20 > Applied to dpdk-next-virtio, with the title changed to "fix feature > negotitation". >=20 Thanks. By the way, it's better backporting it to stable branches, however,= I forget to CC stable@dpdk.org.