From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C7CAF5599 for ; Wed, 26 Apr 2017 07:44:09 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2017 22:44:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,253,1488873600"; d="scan'208";a="80911558" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 25 Apr 2017 22:44:08 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Apr 2017 22:44:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Apr 2017 22:44:07 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Wed, 26 Apr 2017 13:44:05 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "thomas@monjalon.net" , "Michael S. Tsirkin" Thread-Topic: [PATCH 2/3] net/virtio: clean up LSC setting Thread-Index: AQHSvkjlGQB50Zos5E+qJHVB6nfh0KHWmlaAgACHunA= Date: Wed, 26 Apr 2017 05:44:05 +0000 Message-ID: References: <1493182371-34295-1-git-send-email-jianfeng.tan@intel.com> <1493182371-34295-3-git-send-email-jianfeng.tan@intel.com> <20170426053235.GF11512@yliu-dev.sh.intel.com> In-Reply-To: <20170426053235.GF11512@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 05:44:10 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, April 26, 2017 1:33 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; thomas@monjalon.net > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting >=20 > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote: > > Clean up LSC setting: >=20 > Firstly, this patch does two things. There should be two patches. I just merged them into one to adapt to the name of "clean up" :-) >=20 > > - LSC flag is set in several places, but only the last one takes > > effect; so we just keep the last one. > > - As we already change to use capability list to detect MSI-X, remove > > the redundant MSI-X detection in legacy devices. >=20 > However, there is no capability list for legacy device. When I try legacy device on QEMU (disable-modern=3Dtrue), I did detect MSI-= X capability. So does virtio spec mean legacy devices do not have vendor-sp= ecific capability list? Thanks, Jianfeng